Re: [PATCH v4 0/4] device_schedule_reprobe(): core helper and conversions

[Daniel Golle <daniel@makrotopia.org>]

Hi Greg,

On Sat, Oct 17, 2026 at 09:55:17AM +0100, Daniel Golle wrote:
> iwlwifi and hci_h5 re-probe their own device from a work item in module
> text ending in module_put(THIS_MODULE), which a concurrent rmmod can
> race, and nothing ties the re-probe to the binding that asked for it.
> btintel_pcie re-probes synchronously from its own reset work. This
> series adds device_schedule_reprobe() to the driver core and converts
> all three.
> 
> Tested on an Intel AX101 with patches 1 to 3, PROVE_LOCKING and
> DEBUG_OBJECTS_WORK: a re-probe, and an unbind, rmmod, PCI removal,
> suspend and reboot with one pending. The unbind and the removals
> cancelled it, and it ran after resume. The stock iwlwifi code undid
> the unbind, and rmmod with its work held just past module_put() oopsed
> in lockdep. Patches 3 and 4 are untested for lack of hardware.

Now that the most hardcore merge-window ever is over and v7.4-rc1 is
out, can you take a look at this?

The series has received positive feedback and was tested by some more
of the bluetooth folks by now, and is immediately useful to address
currently buggy behavior of existing popular driver, and prevent the
same wrong pattern from being duplicated into new drivers.


Cheers


Daniel