mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Seunghyun An <san55@wisc.edu>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	 David Hildenbrand <david@kernel.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	 "Liam R . Howlett" <liam@infradead.org>,
	Jann Horn <jannh@google.com>, Pedro Falcato <pfalcato@suse.de>,
	 Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	Suren Baghdasaryan <surenb@google.com>,
	 linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/2] mm: avoid redundant reads of the vm_refcnt cacheline in anonymous faults
Date: Tue, 10 Nov 2026 11:03:10 +0000	[thread overview]
Message-ID: <avLxcf8KaFP_XPnM@gremlin> (raw)
In-Reply-To: <20261110000002.1834454-1-san55@wisc.edu>

Thanks for the report.

You are a complete newcomer to mm, and you are sending very subtle changes
to a core part of it, so I am not confident that you have the depth of
understanding the kernel requires for such work. See
https://docs.kernel.org/process/generated-content.html

I'll therefore take over this change and treat this as a bug report.

I will give you due credit for reporting the issue of course.

I'd like to collaborate on the perf measurements however, so if you could
re-run your test results on my series when I send it that'd be appreciated.

In general it seems that the actual issue is the debug assertion, given you
state only vma_has_anon_rmap() as a problem here.

In general in future - while we're fine with you using LLMs, newcomers
should work on small, incremental changes to mm to build up understanding
first.

--
Cheers, Lorenzo

  parent reply	other threads:[~2026-11-10 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  0:00 Seunghyun An
2026-11-10  0:00 ` [PATCH 1/2] mm/rmap: use vm_pgoff for anonymous VMAs in linear_anon_page_index() Seunghyun An
2026-11-10 11:25   ` Pedro Falcato
2026-11-10 12:59     ` Lorenzo Stoakes (ARM)
2026-11-10  0:00 ` [PATCH 2/2] mm/vma: only assert VMA stability in vma_has_anon_rmap() with CONFIG_DEBUG_VM Seunghyun An
2026-11-10 11:03 ` Lorenzo Stoakes (ARM) [this message]
2026-11-10 14:34   ` [PATCH 0/2] mm: avoid redundant reads of the vm_refcnt cacheline in anonymous faults Seunghyun An

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avLxcf8KaFP_XPnM@gremlin \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@kernel.org \
    --cc=jack@suse.cz \
    --cc=jannh@google.com \
    --cc=liam@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pfalcato@suse.de \
    --cc=san55@wisc.edu \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®