mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Cole Leavitt <cole@unwrap.rs>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Mika Westerberg" <westeri@kernel.org>,
	"Andreas Noever" <andreas.noever@gmail.com>,
	"Yehezkel Bernat" <YehezkelShB@gmail.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thunderbolt: Don't resume the software CM if the host controller is gone
Date: Tue, 10 Nov 2026 11:33:59 +0100	[thread overview]
Message-ID: <avLzF-e6lTqrQM-7@wunner.de> (raw)
In-Reply-To: <20261108051829.152803-1-cole@unwrap.rs>

On Sun, Nov 08, 2026 at 12:18:29AM -0500, Cole Leavitt wrote:
> For 1/2: the trigger on this machine is gone with the new BIOS, but the
> ordering problem is in pciehp itself. A device replacement detected in
> pciehp_resume_noirq() still starts the removal from the IRQ thread in
> the middle of the noirq phase, unserialized against ->resume_noirq() of
> the drivers below the port (on today's mainline, fa4ad798f6f6,
> pciehp_core.c:310 calls pciehp_request(), and pciehp_ctrl.c:145 wakes
> the IRQ thread directly unless pciehp_poll_mode is set). Bjorn, Lukas:
> if that is not worth changing without a reproducer on correctly
> configured hardware, I will drop 1/2 as well.

I think the proper solution is to hold the device_lock() in
device_resume_noirq(), i.e. this needs to be addressed in the
driver core's device power management code, not in pciehp or
individual device drivers.

However as you're saying there's no reproducer anymore and
changing device_resume_noirq() is a bit risky.

Thanks,

Lukas

      parent reply	other threads:[~2026-11-10 10:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18 16:37 [PATCH 0/2] PCI: pciehp / thunderbolt: Fix resume with a slow Thunderbolt host link Cole Leavitt
2026-10-18 16:39 ` [PATCH 1/2] PCI: pciehp: Defer device replacement handling until ->resume() Cole Leavitt
2026-10-18 16:39   ` [PATCH 2/2] thunderbolt: Don't resume the software CM if the host controller is gone Cole Leavitt
2026-10-19  4:29     ` Mika Westerberg
2026-11-08  5:18       ` Cole Leavitt
2026-11-09 23:30         ` Bjorn Helgaas
2026-11-10 10:33         ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avLzF-e6lTqrQM-7@wunner.de \
    --to=lukas@wunner.de \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=cole@unwrap.rs \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®