From: Jarkko Sakkinen <jarkko@kernel.org>
To: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, sumit.garg@oss.qualcomm.com,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tpm: add OP-TEE transport core and a discrete TPM driver
Date: Tue, 10 Nov 2026 17:14:00 +0200 [thread overview]
Message-ID: <avM0uIlZxZIga4dY@kernel.org> (raw)
In-Reply-To: <20261110141923.3100770-2-jorge.ramirez@oss.qualcomm.com>
On Tue, Nov 10, 2026 at 03:19:08PM +0100, Jorge Ramirez-Ortiz wrote:
> Some platforms place a real (discrete) TPM on a bus that only the secure
> world can drive. OP-TEE owns that bus, so the normal world cannot reach
> the chip directly; it instead exposes a mediator trusted application
> that relays TPM2 commands. Add a driver that talks to that application
> and presents the chip as a standard TPM2 character device, so the
> normal-world TPM stack works unchanged.
>
> This is a separate driver from the firmware-TPM one rather than a reuse
> of it. The TEE transport is the same and is shared through a common
> core, but the device identity differs: the firmware TPM uses its own
> application and a public-login session, whereas a discrete chip needs
> its own application and is restricted to kernel access so that user
> space and other applications cannot submit raw commands to it. Folding
> both into one driver would also break on a platform that has both.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
Looks pretty good. Did you check the Sashiko remark?
https://sashiko.dev/#/patchset/20261110141923.3100770-1-jorge.ramirez%40oss.qualcomm.com
Br, Jarkko
next prev parent reply other threads:[~2026-11-10 15:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 14:19 [PATCH v2 0/2] tpm: OP-TEE transport core for discrete and firmware TPMs Jorge Ramirez-Ortiz
2026-11-10 14:19 ` [PATCH v2 1/2] tpm: add OP-TEE transport core and a discrete TPM driver Jorge Ramirez-Ortiz
2026-11-10 15:14 ` Jarkko Sakkinen [this message]
2026-11-10 14:19 ` [PATCH v2 2/2] tpm_ftpm_tee: use the tpm_optee transport core Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avM0uIlZxZIga4dY@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jorge.ramirez@oss.qualcomm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sumit.garg@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®