Re: [PATCH 08/14] mfd: remove unused aat2870 driver

["Nuno Sá" <nuno.sa@analog.com>]

On Sat, Sep 12, 2026 at 11:20:47PM +0100, Jonathan Cameron wrote:
> On Thu, 10 Sep 2026 20:14:15 +0200
> "Arnd Bergmann" <arnd@arndb.de> wrote:
> 
> > On Thu, Sep 10, 2026, at 18:40, Svyatoslav Ryhel wrote:
> > > __ 
> > > Hello Arnd! May you please spare AAT2870 from being removed? I have a 
> > > device which uses aat2870 (LG Optimus 2X P990 Tegra 2, not upstreamed 
> > > yet, but in process as well) and atm I am working on converting this 
> > > driver to use OF. Thank you!  
> > 
> > Sure, I have removed this patch from my series now.
> > 
> > > P. S. If you are planning to remove more old drivers, please CC me in 
> > > since I may be interested in some additional driver upgrades for 
> > > devices I own.  
> > 
> > Please have a look at
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=board-remove-7.3
> > 
> > I tried to be careful about figuring out exactly which drivers are
> > unused, but I'm sure there are still a few false positive and false
> > negative ones in there. I've added the current list of driver files below,
> > let me know if you see something that shouldn't be there.
> Hi Arnd
> 

...

> 
> > drivers/iio/adc/ad7793.c
> Maybe. Analog devices ack needed.
> 
> Production part but this one indeed fails to probe.  Analog
> folk, do you want to fix this one up?

Given it's production we should fix. Looking at platdata seems to nicely
fir in DT. Issue is that I don't have HW with me to test. So I'll maybe
just remove platdata and assume some defaults.

> 
> > drivers/iio/adc/ad7887.c
> No to dropping this.
> 
> Production part - should work fine with defaults in driver.
> Could like the others drop the platform data handling.
> 
> > drivers/iio/adc/lp8788_adc.c
> Probably
> 
> Sub driver of an MFD.  I'm fine with that going if we know
> the mfd is no longer in use.
> 
> > drivers/iio/adc/lpc18xx_adc.c
> > drivers/iio/dac/lpc18xx_dac.c
> Probably
> 
> Likewise these two.
> 
> > drivers/iio/frequency/ad9523.c
> Maybe. Analog Devices ack needed.
> 

Hmm we definitely use this one and we have OF support out of tree with
likely some DT abuse of what can be in DT or not. Not sure if I have
some HW around but we'll need to fix it.

In general for ADI parts, I think we can drop the ones that are not
recommended for new designs. All the others I tempted to say we should
keep. Naturally we need to fix all the drivers that do not compile
without platdata. And for the ones with defaults we can also just remove
platdata and use the plain defaults.

- Nuno Sá