Re: [PATCH v2 0/4] KSM: introduce only_merge_zero_pages

["Xu Xin (vivo)" <xu.xin@linux.dev>]

On Tue, Nov 10, 2026 at 10:08:00AM +0000, Lorenzo Stoakes (ARM) wrote:
> All-in-all this seems to be adding more complexity to a current major AI bugfix
> target, in a cycle where we're not really looking for significant new
> functionality.
> 
> So given [0] I wonder if this could be deferred to the next cycle? David, what
> do you think?
> 
> In any case the code is pretty rough from a scan (I reviewed one of the commits
> to have a mini-dig) and looks very LLM-generated.
> 
> It needs _human_ polishing before we could take it regardless.

I don't mind deferring this to the next cycle.

Also, the patches themselves are all written by Jinjiang and me; some of the
descriptions may have been translated or generated with LLM, which helps improve
efficiency for non-native English speakers like me. If you don't like that style,
I'll try to avoid it and write the commit messages manually.

Thanks.
> 
> And additionally, you are shoving yet more logic into already horribly massive
> functions in dire need of rework.
> 
> Sorry but the technical debt does have to be paid at some point, so I think this
> would need some initial patches doing something about that before the rest of it
> anyway.

Fine, I'll try but it's not that easy to refactor scan_get_next_rmap_item().

> 
> [0]:https://lore.kernel.org/linux-mm/a2f584f6-e382-4876-aa6d-d5a34de6ee59@kernel.org/
> 
> --
> Cheers, Lorenzo