From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794318539; b=nosFoQBE8cf2meZTFYBoEk9ZSWOOvHvgtGndfLXc0ICVl+BLkymqXY2PtUU4fhytvYky WkegsZJHHZGR9GJjBkHQhH5cjy2H3ir4+TCAqkXkx9Cu1FBXt+WlVpDpT44JfBNY/QqCk So90hPvY3eNVa9BHBsviFo+MDfDjHphaxJb6xoERe9ImjCUlxhsEBO83CiE+viDVO8DuG M4loodOTm4hnEhEbC7Fmvc4fahaa0pmrTqTWHdtyI6KBci4F45brE3+f3C25KgP5p/O0t XMxqbPIKbKhmW3iqKgSmrBlfJ+3feHtRoubeUR4oUspr0hN40/ZkUberCqYuECvxrog== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794318539; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=q+YMVvkEa8uaOBbexYkxUBo5dx74+xkphIFCSV1U0i8=; b=E0IZlhhjlyF2THkEJF5v4GJ1sf6Rh2niRXa1JAr/hFgsQOiPGH1uNXjnYQkC+3IskwLA +Ws5CQwmnNjQiWm/32EX0Frpl9xJr6EBpdlcKJPfV02nbY16FtttjkHvT60pRQXQea9I5 TYMlKKxJfr/IdsMAMltGDeNIaQ4pHl4SO+tD7ev2jgFH1hB8vMNd+3E1evGkr2DLiRMuj ggAfVEbdW3DRWi0KWoYYhogIlo3JFHtvsOUADAjkkBApjywze3euLEbBILvGff1lTAS6S HBN/DLOz5XVQG34LngduD9brZO0VqJsGYeLvLV//+YiQek4FzPMPMS2v2ytdxCRMs5Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=U3pZ+JWc; arc=none smtp.remote-ip=209.85.221.50 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8FE60A2600 for ; Tue, 10 Nov 2026 13:48:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5B8FE60A2600 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=U3pZ+JWc Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-492f563d1c6so754390f8f.3 for ; Tue, 10 Nov 2026 05:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794318538; x=1794923338; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=q+YMVvkEa8uaOBbexYkxUBo5dx74+xkphIFCSV1U0i8=; b=U3pZ+JWcNB+aUIQUkCWa/CoRrIxZottPyQ/U/RqEIHU8QvhFvxBkH2cALjw59mxU2S tt+WKohbj4ODaJ5yG3Ju4uUFACHMACrWvr0q3gyxNuzowYiagaIFfTSnDtuoIuKM6LaB jczTSMfVDYtSHUEIbpgykRs/LmEJWXIFOjVa8MPeUGbUP04K57Aos0p8ZvnVM/kOZNPp ShalNlCmNFobzlT+72+oz4RhDF8dNTyzRnITgCQBaKgmQ55R9vDev1chitgL2HL94v/V hM/daagI3jOeMww1OHmdvFVyF3i3oaviGDjg9IIbkWu4TNd1/31arkBsq1H5nOp08y+l 0e3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794318538; x=1794923338; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=q+YMVvkEa8uaOBbexYkxUBo5dx74+xkphIFCSV1U0i8=; b=l3vLFNqr5cEHgrCS8uS1RT0dxnSmElJD59INxfZW9INbJqsPQiPpHgWGTHloFKq2pA mGMUOsUzL/q9RhVJj9sQcokObCOEVipkLeccYR2MR3/k4ApmmLQn0g2rNXJ/3NhtPmT8 /LlnC17WUaahsB7d9qAPOAsXMZLbZB9+h7nsh9FVtEXsLkFDsoqrlTDNAh9OpshurMPp IdEUG6XELzZaqD3Q4lQNWSlHFKiNuaUe6qvHhqEF5gaQAAl4CHcvaWyYcdTJedY9ZhZr ubX5ZTf+m9HROHwfbO/UaAsx6CYNXqY4WQPtoXQMiqSr3zSb7VHM+Pa+19/GtAs4Wf7+ 5tPA== X-Forwarded-Encrypted: i=1; AL+hErGaharNZpDYpB9UAqJ4pUhSvJXx7YNflI5ALptezt7cS2/WzWcgqtckGtcmk+mgCGJqu/cJHwgsIXyeloY=@vger.kernel.org X-Gm-Message-State: APuU4Z8AlaYUx3HCk4pq59ViKKJUL+BMKCutIfDlV3EM4VR9yGnDUtXV poalE8fOALir2MdwiXPFjqi+VRQNJMnkTziRqOldtWz9K102+hnRnkQg X-Gm-Gg: AYBFou2Cillug1mfVvldOgbKOmVa1tpmrTIicS7u1aQMMRWSeDxvlpVv+uQNfKLbJdP OgIe9m3IGVUp5RjobPsoiQ56nbdwBJ0pSXwcOp4sWyl0yqmovGY0KpmJVU/sTd0UwU907Hg78pZ PE5rRV/FlVAb+AmzIXkzgcIDbTFKKXyn4AYkYK+LE1IqNS2KN9+ghXkxzSZ0ecWaiJz+OV4WiGr S+vfG+kb+kJgzaRtSz0guf/3v7p4Xa2QRYxkGXwao6YQgjjIv/jaqwy4GHRvTVW3B0DjuAfkzNa C7xQ/ZvZm+c8Dyp99cp7krrfk/rXAUEKy8YbAHebmvESy34RADepnUOjQOuC5DntI9jWW4AbSvX djYMfcpM4G8a85F21oZyPICgI/YUgEFI/RNPVRUoEQE9vEwmxDGRxDRpHpp4Y8nsB6GOY3FvLEd hyBQYjD7HROojI2/kzu2NAImPhnsCfemVGyF3p8P2B4KD3UdgIVdMtamUSSv/5BDArgwBcU1oQ8 QezG4YLcsi1vBqFdfVGqkZe+QcQXV6HWcvCQ2Dl7eZ/Kqryj9z6Vw/h+O4yAlZ/iuF2fb6aqA1n tC0hW2hxhi6F1PL0AqgsWoRcDGkmRZqxUQcigg== X-Received: by 2002:a05:6000:4006:b0:498:a72d:c097 with SMTP id ffacd0b85a97d-498a73d0414mr3856529f8f.19.1794318537546; Tue, 10 Nov 2026 05:48:57 -0800 (PST) Received: from mail.gmail.com ([2a04:ee41:4:b2de:1ac0:4dff:fe0f:3782]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4984e26f8e3sm4483376f8f.1.2026.11.10.05.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 05:48:56 -0800 (PST) Date: Tue, 10 Nov 2026 14:00:27 +0000 From: Anton Protopopov To: bot+bpf-ci@kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, almagui@kernel.org, john.fastabend@gmail.com, qmo@kernel.org, brauner@kernel.org, kpsingh@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev, sashal@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, martin.lau@kernel.org, mason@kernel.org Subject: Re: [PATCH v2 bpf-next 01/18] bpf: Add BTF ID sets for fmod_ret targets Message-ID: References: <20261109170550.141443-2-a.s.protopopov@gmail.com> <4bd4574839415920b87e63fe2c5340ec54df15620210a2aad053ea7d7be14b94@mail.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bd4574839415920b87e63fe2c5340ec54df15620210a2aad053ea7d7be14b94@mail.kernel.org> On 26/11/09 05:42PM, bot+bpf-ci@kernel.org wrote: > > bpf: Add BTF ID sets for fmod_ret targets > > TL;DR: Nits only in resolve_btfids: a comment may misleadingly suggest entries > with a missing function are rejected (they only warn), and a new outer "off" > is shadowed by the inner one. Will fix both nits (will be resending series in any case, as verifier changed again since then) > > diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c > > --- a/tools/bpf/resolve_btfids/main.c > > +++ b/tools/bpf/resolve_btfids/main.c > > [ ... ] > > > @@ -1344,7 +1355,16 @@ static bool is_arena_param(const struct btf *btf, const struct btf_param *param) > > param_name_has_suffix(name, PARAM_SUFFIX_ARENA_NULLABLE); > > } > > > > -static int collect_kfuncs(struct object *obj, struct btf2btf_context *ctx) > > +typedef int (*set_func_fn)(struct btf2btf_context *ctx, const char *name, > > + u32 btf_id, u32 flags); > > + > > +/* > > + * Call FN for each function in the BTF ID sets which have SET_FLAG set. Reject > > + * an entry with flags other than ALLOWED_FLAGS, also if its function is missing. > > + */ > > This isn't a bug, but could this read "even if its function is missing"? > As written it can suggest that entries with a missing function are > rejected, while collect_set_funcs() only prints a WARN, increments > warnings and continues to the next entry. > > [ ... ] > > > @@ -1356,24 +1376,39 @@ static int collect_kfuncs(struct object *obj, struct btf2btf_context *ctx) > > for (next = rb_first(&obj->sets); next; next = rb_next(next)) { > > struct btf_id_set8 *set8; > > struct btf_id *set_id; > > - u64 set_addr; > > + u64 set_addr, off; > > [ ... ] > > > for (u32 i = 0; i < set_id->cnt; i++) { > > size_t off = (char *)&set8->pairs[i] - (char *)set8; > > const char *name = find_name_by_addr(obj, set_addr + off); > > This isn't a bug, but would a distinct name for the new outer offset, for > example set_off, make it clearer which offset "set_addr + off" uses here? > > The inner "size_t off" (offset of a pair within the set) now shadows the > outer "off" (offset of the set within .BTF_ids), and the inner declaration > would trigger -Wshadow. > > > --- > AI reviewed your patch. Please fix the bug or email reply why it's not a bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md > > CI run summary: https://github.com/kernel-patches/bpf/actions/runs/42662799554