From: Cristian Marussi <cristian.marussi@arm.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
imx@lists.linux.dev, Peng Fan <peng.fan@nxp.com>,
linux-amarula@amarulasolutions.com, arm-scmi@vger.kernel.org,
michael@amarulasolutions.com, stable@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Sebin Francis <sebin.francis@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 1/2] clk: scmi: fix SSC spread conversion
Date: Tue, 10 Nov 2026 14:21:55 +0000 [thread overview]
Message-ID: <avMog5kzJpsiUhXn@pluto> (raw)
In-Reply-To: <20261104103620.4054694-2-dario.binacchi@amarulasolutions.com>
On Wed, Nov 04, 2026 at 11:36:02AM +0100, Dario Binacchi wrote:
> The spread_bp field of struct clk_spread_spectrum holds the modulation
> depth in permyriad (1/100 of a percent), as documented in
> clk-provider.h and in the assigned-clock-sscs binding, while the i.MX
> SCMI OEM extension expects a value in tenths of a percent, as pointed
> out by Peng Fan.
>
> The conversion divides spread_bp by 10000 instead of 10, as reported by
> Sashiko, so any valid configuration is truncated to 0 and the hardware
> is silently programmed with no spread at all.
>
> Divide by 10 and fix the comment accordingly.
>
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thanks,
Cristian
next prev parent reply other threads:[~2026-11-10 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 10:36 [PATCH v15 0/2] clk: scmi: fix the i.MX OEM spread spectrum configuration Dario Binacchi
2026-11-04 10:36 ` [PATCH v15 1/2] clk: scmi: fix SSC spread conversion Dario Binacchi
2026-11-10 14:21 ` Cristian Marussi [this message]
2026-11-04 10:36 ` [PATCH v15 2/2] clk: scmi: reject SSC configuration out of the OEM field range Dario Binacchi
2026-11-10 14:43 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avMog5kzJpsiUhXn@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=peng.fan@nxp.com \
--cc=sashiko-bot@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebin.francis@ti.com \
--cc=stable@vger.kernel.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®