From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794321801; b=CfKOdH248R2NiOPzCqP30ZUNqRnWckVYlRu25CT6ytKMLpZ/4zqC7UaP55Max7tidx+4 eRemSv6sD0XvIVNImmv1YFMQKiSgDUCK9NLe2zwiJJx4PDPrBGic2tK532JwlHp/ki3MI v++iXgFn3NHFLBzIBp3ZO8Wqvag1Sj0qng+maQWgQ9T1QScfW77tJo61UWHLR8LFFzTSt k+jo6vgqB44pWOHCQoUliiGf5BquVFXBh/yj+UzZP97G0GbC8SzkShO26/xZ7Tc6NrjDF G+gBuLPJ6Vdgin0CiX5AL7GOuZDpKxTCKEB4VRgl0AiikzKpdOxnEkOHZ/Wkoorutug== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794321801; h=DMARC-Filter:Received:Received:DKIM-Signature:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=xy3xjpeII+ISxdGXftLppTbqcukaKKLwMFzsxm43o7w=; b=b0m9ankriEzrx2vTrlp8dWrxU1XxLs3XuJLzcjWFO3m5u/IZ56qULwYJmfB+LT80N+W0 yVPYh6OIm0ji8U6AkQhJpyRuO1Kfdr6Fk+Gjx1kmdx791zVoRmDXSh2NdY1sNnRLGeiL+ r3fdc+lFZN1siJseGBiGwjKHVYjahu2i1pdQ7OhW27BITdQnsnKNFcg0F24IpCes4PxQn baHEIEj36wgUqeF/l2SUXCLukFdBtAzZm7wpBfymdLrkAk00DdMkSprxuHbEpMaSspD0Q /YxJU4uESRJmaarLoeJIaq23890+BC9NtCtFXM2R6hng6/HSdmI2eIe2kKbNi8JbtgA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=FnppE1Qb; arc=none smtp.remote-ip=217.140.110.172 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D547860A263A; Tue, 10 Nov 2026 14:43:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D547860A263A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=FnppE1Qb Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 440DA1477; Tue, 10 Nov 2026 06:43:17 -0800 (PST) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E8AA3F632; Tue, 10 Nov 2026 06:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1794321800; bh=vd5r4VdqjOBRM0Vqs8yo1BB1AiJgxUtyT/L7aP/x6IQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FnppE1QbxEEUZLESdF1mATcmg3WUDOHbfMl1F3vRGImPAYpG4d57tCF5oZeuXZD2i MRyW0CUoTQ+gkYoDYJhVc6IgDD/4QRIwH7EUqb0QNLUnrKkAWZ+Xmoeae3UF/C9f7V qrs/WE8u86pOF8n5ikhqhiQJiKJB2FxpRQs7Ds6Y= Date: Tue, 10 Nov 2026 14:43:15 +0000 From: Cristian Marussi To: Dario Binacchi Cc: Sudeep Holla , Cristian Marussi , imx@lists.linux.dev, Peng Fan , linux-amarula@amarulasolutions.com, arm-scmi@vger.kernel.org, michael@amarulasolutions.com, Brian Masney , Jerome Brunet , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v15 2/2] clk: scmi: reject SSC configuration out of the OEM field range Message-ID: References: <20261104103620.4054694-1-dario.binacchi@amarulasolutions.com> <20261104103620.4054694-3-dario.binacchi@amarulasolutions.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261104103620.4054694-3-dario.binacchi@amarulasolutions.com> On Wed, Nov 04, 2026 at 11:36:03AM +0100, Dario Binacchi wrote: > The i.MX SCMI OEM extension stores the spread in an 8-bit field, in > tenths of a percent, and the modulation frequency in a 16-bit field. > > FIELD_PREP() silently truncates values that do not fit in the target > field. Moreover, the conversion from permyriad to tenths of a percent > turns values below 10 permyriad into zero, which is then passed to the > firmware as no spread at all. > > Reject these cases with a warning instead of silently programming a > configuration different from the requested one. > > A request with no spread method disables SSC, so send a zeroed > configuration to the firmware in that case, without checking the > spread and the modulation frequency, which are meaningless then. > > Signed-off-by: Dario Binacchi > LGTM. From: Cristian Marussi Thanks, Cristian