mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Zhe Liu <liuzhe1@kylinos.cn>
Cc: axboe@kernel.dk, josef@toxicpanda.com, yukuai@fygo.io,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 0/3] blkcg: decouple cgroup v1 I/O accounting from throttling
Date: Tue, 10 Nov 2026 06:06:46 -1000	[thread overview]
Message-ID: <avNBFpWArSrjv6Qv@slm.duckdns.org> (raw)
In-Reply-To: <20261110103201.762861-1-liuzhe1@kylinos.cn>

On Tue, Nov 10, 2026 at 06:31:58PM +0800, Zhe Liu wrote:
> Commit a3166c51702b ("blk-throttle: delay initialization until
> configuration") deferred throttle policy activation until an I/O limit is
> configured. However, cgroup v1 accounting still lives in the throttle
> policy and is performed after the activation check in blk_should_throtl().
> Without an activated throttle policy, v1 statistics such as
> blkio.throttle.io_service_bytes remain zero even while I/O is issued.
> 
> This forces cgroup v1 users to configure the throttle policy just
> to obtain I/O statistics, even when no throttling is needed.

Maybe just add a module option or sth to blk-throtl to initialize eagerly? I
don't think it makes sense to update cgroup1 significnatly at this point.

Thanks.

-- 
tejun

      parent reply	other threads:[~2026-11-10 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 10:31 Zhe Liu
2026-11-10 10:31 ` [PATCH 1/3] blkcg: allow printing rwstat samples without policy data Zhe Liu
2026-11-10 10:32 ` [PATCH 2/3] blkcg: move cgroup v1 I/O statistics out of the throttle policy Zhe Liu
2026-11-10 10:32 ` [PATCH 3/3] blkcg: account cgroup v1 I/O before checking throttle activation Zhe Liu
2026-11-10 16:06 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avNBFpWArSrjv6Qv@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuzhe1@kylinos.cn \
    --cc=yukuai@fygo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®