Re: [PATCH 2/2] iio: pressure: dps310: add a data-ready trigger

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Nov 10, 2026 at 05:42:54PM +0200, Rupesh Majhi wrote:
> With an interrupt wired to SDO, the chip can signal each new pressure
> result. Expose it as a trigger, so captures follow the measurements and
> scans carry the time the result was ready, not when the handler ran.
> 
> Polarity follows the interrupt type. Status latches while the interrupt
> is disabled, so it is cleared before enabling. The trigger is not the
> default, so FIFO mode without a trigger is unchanged.

...

> +static int dps310_trigger_set_state(struct iio_trigger *trig, bool state)
> +{
> +	struct dps310_data *data = iio_trigger_get_drvdata(trig);

	struct regmap *map = data->regmap;

> +	unsigned int status;
> +	int rc;
> +
> +	guard(mutex)(&data->lock);
> +
> +	/* Status latched while disabled would fire a stale interrupt */
> +	if (state) {
> +		rc = regmap_read(data->regmap, DPS310_INT_STS, &status);

(as per below)

> +		if (rc)
> +			return rc;
> +	}
> +
> +	return regmap_assign_bits(data->regmap, DPS310_CFG_REG, DPS310_INT_PRS,
> +				  state);

	return regmap_assign_bits(map, DPS310_CFG_REG, DPS310_INT_PRS, state);

> +}

...

> +static int dps310_trigger_probe(struct dps310_data *data)
> +{
> +	struct device *dev = &data->client->dev;

	struct regmap *map = data->regmap;

> +	struct iio_dev *iio = data->iio;
> +	int irq = data->client->irq;
> +	bool active_high;
> +	int rc;
> +
> +	switch (irq_get_trigger_type(irq)) {
> +	case IRQ_TYPE_LEVEL_HIGH:
> +	case IRQ_TYPE_EDGE_RISING:
> +		active_high = true;
> +		break;
> +	case IRQ_TYPE_LEVEL_LOW:
> +	case IRQ_TYPE_EDGE_FALLING:
> +		active_high = false;
> +		break;
> +	default:
> +		return dev_err_probe(dev, -EINVAL, "Unsupported interrupt type\n");
> +	}

> +	rc = regmap_assign_bits(data->regmap, DPS310_CFG_REG, DPS310_INT_HL,
> +				active_high);

	rc = regmap_assign_bits(map, DPS310_CFG_REG, DPS310_INT_HL, active_high);

> +	if (rc)
> +		return rc;
> +
> +	data->trig = devm_iio_trigger_alloc(dev, "%s-dev%d", iio->name,
> +					    iio_device_id(iio));
> +	if (!data->trig)
> +		return -ENOMEM;
> +
> +	data->trig->ops = &dps310_trigger_ops;
> +	iio_trigger_set_drvdata(data->trig, data);
> +
> +	rc = devm_request_threaded_irq(dev, irq, dps310_irq_handler,
> +				       dps310_irq_thread, IRQF_ONESHOT,
> +				       iio->name, data);
> +	if (rc)
> +		return rc;
> +
> +	return devm_iio_trigger_register(dev, data->trig);
> +}

-- 
With Best Regards,
Andy Shevchenko