mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Rik van Riel <riel@surriel.com>
Cc: Yeoreum Yun <yeoreum.yun@arm.com>,
	"David Hildenbrand (Arm)" <david@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Jason Gunthorpe <jgg@ziepe.ca>,
	John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Yuan-Hao Hsu <aa9736195201@gmail.com>
Subject: Re: [PATCH v3 5/6] mm: gup: introduce gup_unshared_pages()
Date: Tue, 10 Nov 2026 21:27:05 +0000	[thread overview]
Message-ID: <avOMKWJe3wwNb2sW@e129823.arm.com> (raw)
In-Reply-To: <5db7a358c293393a93984ac3c3cc58e810edd75a.camel@surriel.com>

On Tue, Nov 10, 2026 at 03:23:15PM -0500, Rik van Riel wrote:
> On Tue, 2026-11-10 at 20:19 +0000, Yeoreum Yun wrote:
> > On Tue, Nov 10, 2026 at 02:21:18PM -0500, Rik van Riel wrote:
> > > On Tue, 2026-11-10 at 14:04 +0100, David Hildenbrand (Arm) wrote:
> > > > 
> > > > So it's all about "number of pages that don't need unsharing".
> > > > 
> > > gup_no_unshare_len() ?
> > > 
> > > a little awkward sounding, but it describes
> > > what it's doing?
> > 
> > Hmm, Wouldn't this name be semantically much the same as keeping
> > the existing gup_unshared_page(), since both essentially convey that
> > no unsharing is required from GUP's perspective?
> 
> The function measures how many pages in
> this current interval do not need to be
> unshared.
> 
> I'm happy with any name, though.
> 
> I would really like to just see this
> code go in, so I can post my two
> GUP series on top, first the batching
> for the GUP-slow path, and then the
> series that allows access_remote_vm()
> and friends to work under the per-VMA
> lock.

@David, If you don't have any strong comments for original name
-- gup_unshared_page(), May I post next version with resolving other
comments so that Rik's series be posted soon?

Otherewise, gup_skip_unshare_pages() works for me.
-- 
Sincerely,
Yeoreum Yun

  reply	other threads:[~2026-11-10 21:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 12:32 [PATCH v3 0/6] mm: gup: batch PTE-mapped large folios in gup_fast_pte_range() Yeoreum Yun
2026-11-09 12:32 ` [PATCH v3 1/6] mm: khugepaged: ignore MADV_HUGEPAGE for shadow stacks Yeoreum Yun
2026-11-09 14:22   ` David Hildenbrand (Arm)
2026-11-09 15:24     ` Yeoreum Yun
2026-11-09 12:32 ` [PATCH v3 2/6] mm: gup: clarify a reason to check pte/pmd in gup_fast_pte_range() Yeoreum Yun
2026-11-10  3:50   ` Rik van Riel
2026-11-10  9:52     ` Yeoreum Yun
2026-11-09 12:32 ` [PATCH v3 3/6] mm: gup: move gup_must_unshare() and INTERNAL_GUP_FLAGS to gup.c Yeoreum Yun
2026-11-10  4:49   ` Rik van Riel
2026-11-10 13:02   ` David Hildenbrand (Arm)
2026-11-09 12:32 ` [PATCH v3 4/6] mm: internal: introduce FPB_LOCKLESS for folio_pte_batch_flags() Yeoreum Yun
2026-11-10  4:51   ` Rik van Riel
2026-11-10 13:02   ` David Hildenbrand (Arm)
2026-11-09 12:32 ` [PATCH v3 5/6] mm: gup: introduce gup_unshared_pages() Yeoreum Yun
2026-11-10  5:26   ` Rik van Riel
2026-11-10  9:58     ` Yeoreum Yun
2026-11-10 13:04       ` David Hildenbrand (Arm)
2026-11-10 13:58         ` Yeoreum Yun
2026-11-10 19:21         ` Rik van Riel
2026-11-10 20:19           ` Yeoreum Yun
2026-11-10 20:23             ` Rik van Riel
2026-11-10 21:27               ` Yeoreum Yun [this message]
2026-11-10 22:35                 ` David Hildenbrand (Arm)
2026-11-10 22:39                   ` Yeoreum Yun
2026-11-10 20:23             ` David Hildenbrand (Arm)
2026-11-09 12:32 ` [PATCH v3 6/6] mm: gup: batch PTE-mapped large folios in gup_fast_pte_range() Yeoreum Yun
2026-11-10  5:46   ` Rik van Riel
2026-11-10 13:09   ` David Hildenbrand (Arm)
2026-11-10 14:04     ` Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avOMKWJe3wwNb2sW@e129823.arm.com \
    --to=yeoreum.yun@arm.com \
    --cc=aa9736195201@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=peterx@redhat.com \
    --cc=riel@surriel.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®