Re: [PATCH v1] drm: Drop #include <linux/mod_devicetable.h> from <drm/display/drm_dp_aux_bus.h>

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 2820 bytes --]

Hello,

On Thu, Aug 06, 2026 at 06:16:06PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Only .c files include <drm/display/drm_dp_aux_bus.h> (see
> 
> 	git grep -l drm_dp_aux_bus\\.h
> 
> ). From the device-id structures that <linux/mod_devicetable.h> provides
> there are:
> 
>  - 8 files using struct auxiliary_device_id;
>  - 2 files using struct i2c_device_id; and
>  - 10 files using struct of_device_id
> 
> (and no other usages; see
> 
> 	git grep -l drm_dp_aux_bus\\.h | xargs grep -oh -E "\<(acpi_device_id|amba_id|ap_device_id|apr_device_id|auxiliary_device_id|bcma_device_id|ccw_device_id|cdx_device_id|coreboot_device_id|css_device_id|dfl_device_id|dmi_(device|system)_id|eisa_device_id|fsl_mc_device_id|hda_device_id|hid_device_id|hv_vmbus_device_id|i2c_device_id|i3c_device_id|ieee1394_device_id|input_device_id|ipack_device_id|isapnp_device_id|ishtp_device_id|mcb_device_id|mdio_device_id|mei_cl_device_id|mhi_device_id|mips_cdmm_device_id|of_device_id|parisc_device_id|pci_device_id|pci_epf_device_id|pcmcia_device_id|platform_device_id|pnp_(card_)?device_id|rio_device_id|rpmsg_device_id|sdio_device_id|sdw_device_id|serio_device_id|slim_device_id|spi_device_id|spmi_device_id|ssam_device_id|ssb_device_id|tb_service_id|tee_client_device_id|typec_device_id|ulpi_device_id|usb_device_id|vchiq_device_id|vio_device_id|virtio_device_id|wmi_device_id|x86_(cpu|device)_id|zorro_device_id|cpu_feature)\>" | sort | uniq -c
> 
> ).
> 
> The 8 files using struct auxiliary_device_id already include
> <linux/auxiliary_bus.h>, the 2 files using struct i2c_device_id include
> <linux/i2c.h> and drm_dp_aux_bus.h itself includes <linux/device.h>
> which provide struct auxiliary_device_id, struct i2c_device_id and
> struct of_device_id respectively.
> 
> So the include of <linux/mod_devicetable.h> can just be dropped. This
> gets one step closer to being able to remove that header.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

This is still all true, including the statistics (as of next-20261110)
and the patch still applies fine.

Can someone get convinced to apply it?

Thanks
Uwe Kleine-König

> ---
>  include/drm/display/drm_dp_aux_bus.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/drm/display/drm_dp_aux_bus.h b/include/drm/display/drm_dp_aux_bus.h
> index 8a0a486383c5..ca8db8ccc1f9 100644
> --- a/include/drm/display/drm_dp_aux_bus.h
> +++ b/include/drm/display/drm_dp_aux_bus.h
> @@ -11,7 +11,6 @@
>  #define _DP_AUX_BUS_H_
>  
>  #include <linux/device.h>
> -#include <linux/mod_devicetable.h>
>  
>  /**
>   * struct dp_aux_ep_device - Main dev structure for DP AUX endpoints
> 
> base-commit: 1701fda2f58e345c050f4309971bdc07cd6146ba
> -- 
> 2.55.0.11.g153666a7d9bb
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]