From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.129 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794385203; b=eDWT1tjBmypDvdbR9LpZtmCa7b6uMoDfyQ4MRPeK2O5HwLG2PNL2P1EMPSBrvTOJtYRa xvUQxabwLX/y5ZGSg7h3j2rcBOG4l4eXjrFOPKufSFnfDCjIBO4wJjTvHL6c0VMhF4AYa wq9Xdh04+hZSOW9Jy+jH2myHNF/A4z5xSuVDBUhcSRilJ2+lc/NV1OHtv9eOV8LEiMunK de+SpJrX1NLzSXlyWJAh84IrWf62rXCsyosHP03XQ2kedwNtsrUuSnIJAOT4wuw5YGdHZ a5qbb+rcHIG5Wf9P1M5GA5GQ53SqvVj56wZKh2e0bfpzcQvGDMJPKrXcxcao78aiC/g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794385203; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=G3d3b2tM519kuIvjkSRexg4H0KkdNZyWkRnjj4rZTd4=; b=YT+dWfkWsArIAnUBf4DTsrtrgs9pQ9RmQyNLISyf/BruHNJu8/CtYxMCZhOLlh2WKT0P 0JwGbkfvlaCJuPW0J+rpw9X0ugF1EPzyeHt8556fBH7kWkrlKBkMj9Y44Ac5oBTc3siJ0 hWTIUatDx3mg2p0CKrFLK2hdl1NEAWRXbpWsbesENk5NRwnaH0i+jT7OxtvOHjTeFYmMz oINvpvBv+jnxtIwGlFlumk0g4XHZ0ioAt2QCzsdW9hqyUy6hnW+ZgtPbdr0RNzhnPdDHc N/ema20eEp5xTihjCnDwbgxWIpLcdXv7b6hAB5Bz+jvSDdgc4mMVyOWVI/59cPl4xZg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=iyOp41w6; arc=none smtp.remote-ip=91.218.175.129 Received: from mta0.migadu.com (out-129.mta0.migadu.com [91.218.175.129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEEC9606A320 for ; Wed, 11 Nov 2026 08:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AEEC9606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=iyOp41w6 X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=01hkxhMvjpH0YwUfWPSVcu2PhKCcNEL9gg0Q0PcG8gI=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794385199; v=1; x=1794989999; b=iyOp41w6ePFfiABPcVNymqvnRo7CvaC7mYHYLS9IIcdtQDFFSmovUlyn7TOR60F6UJXjYQHx HBdMKlOMlV0Fj9OFgH1bcGEq7R3P7yexH45CjSDoP4/BLlil+pzb4rmq/ZUZgqqgEe0v0YN/1Yc B25Xx13HT1EETMUH+9zTErRQ= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 2365b7a9a39834f0; Wed, 11 Nov 2026 08:19:59 +0000 X-Mizu-Trace-ID: 2365b7a9a39834f0 X-Migadu-Flow: FLOW_OUT Date: Wed, 11 Nov 2026 16:19:49 +0800 From: Hao Li To: Tiezhu Yang Cc: Vlastimil Babka , Harry Yoo , Andrew Morton , Christoph Lameter , David Rientjes , Roman Gushchin , linux-mm@kvack.org, loongarch@lists.linux.dev, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/slub: Genericize x86-specific cmpxchg16b comment Message-ID: References: <20261111011108.29311-1-yangtiezhu@loongson.cn> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261111011108.29311-1-yangtiezhu@loongson.cn> On Wed, Nov 11, 2026 at 09:11:08AM +0800, Tiezhu Yang wrote: > In __kmalloc_nolock_noprof(), update the comment from x86-specific > "cmpxchg16b" to generic "double-width atomic cmpxchg". > > Suggested-by: Harry Yoo > Signed-off-by: Tiezhu Yang > --- > v3: > - add missing Suggested-by tag for Harry > - use shorter commit message as requested > > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 45e077c7526c..090302f1daeb 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -5589,8 +5589,8 @@ static void *__kmalloc_nolock_noprof(DECL_TOKEN_PARAMS(size, token), gfp_t gfp_f > if (!(s->flags & __CMPXCHG_DOUBLE) && !kmem_cache_debug(s)) > /* > * kmalloc_nolock() is not supported on architectures that > - * don't implement cmpxchg16b and thus need slab_lock() > - * which could be preempted by a nmi. > + * don't implement double-width atomic cmpxchg and thus need > + * slab_lock() which could be preempted by a nmi. > * But debug caches don't use that and only rely on > * kmem_cache_node->list_lock, so kmalloc_nolock() can attempt > * to allocate from debug caches by > -- > 2.42.0 > Looks good to me. Reviewed-by: Hao Li -- Thanks, Hao