From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794393361; b=vbSopIH9/iTEVCV4nrfMVM+/pqpYceBp5xb5sT7wEeWPk5WUbRv05oKLB7VTzKpzWnhi 7PKlGRxuR4rs65KKxFvILYtE3pIgQceH/RHUf5ZDA0pNt0KTBryX2aMRY6CjkNIahDOCW 8LKfcddxjJILJJRRWX0s9r3f8dpV72ktonNtwmIllEI5hnK3JdxpKVVx/KlEATae7OSSS rS8Sr0N/ewjYOY3bv5LL2WEGTl1R3Yz95/pRBNKqupW9hjNGODF3VWSyF73UvZcAnJrff EjtF/o1myonsHavm9JIH9n3pL/LsGfLiyQ/wc1PoRIyzhQXVDSwrEs72p6i8p/HJlOA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794393361; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=3/Qm8F9jS9txwPiJ9OMTxV+9BbKodPA2/hA4qfKSOTY=; b=gB+Ns0bIXbkqEISK/ZG8v8pySh52nZUyY+Vs8dslf20FxkjOXT0CY5Qi0jVZAIlISsXU mIuM1HXf2Kr5pg6R8fktwP0xHbQJ3W5z52WC5wfy1iRqrMRyIIRY2aep1eghekLm5/LvQ MRUor/vEzTO17dNuI0X1lL7C6+Amuka2a4uV7qsD2ES8ATvOXKxZmMOtF410axbH1xKkQ P/mJfVEuK/kK0B6LwNh/F7eXEjgHVzbXpnhEgveCKlYJH44CCPjIUF4c3uaSSHM2jk4mB EjTZXaN8g1Sgmq+P4lXPEp0zIo1yuNIAzXAezDfCLP62RB/IligP+0IuiISMGxB+bAQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ekdPx+2L; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1345606A339; Wed, 11 Nov 2026 10:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ekdPx+2L Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACCD91F00A05; Wed, 11 Nov 2026 10:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794393360; bh=3/Qm8F9jS9txwPiJ9OMTxV+9BbKodPA2/hA4qfKSOTY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ekdPx+2LWD0BQ/C3SpSBmJYPcQSKYU9rl2B5z5fg8d66hMIDCS9kQgX5wH0OFXyqp mM1zaLdTlBmHFxU4H70B38f/o+ymU4bEwsQWp6B3nJ7yHGcxIICCNArodCFiFzSQOn ecov57Sv2N7NEhTF0/mcY/KX0t/jBnjRgDvfgBXYa96MZ42rQhA3DH1Z+ZF6tTXDGN dW3bO0BTpWrbNgeHp4syQPmrkEcJV2iggtkE62VwsmyepRJZCfX4oBwWiUx0sSjyRD 7ajUeab4QZjU2gcdS2WA7VW5SI4S+93QzS3d76IvyvqqtOQon4YKx9ItGmemNAnKEs 0rK9svrg0GVKQ== Date: Wed, 11 Nov 2026 11:35:55 +0100 From: Alejandro Colomar To: Mariia Nikitash Cc: nicolas.dufresne@collabora.com, benjamin.gaignard@collabora.com, p.zabel@pengutronix.de, mchehab@kernel.org, hverkuil+cisco@kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, kees@kernel.org, justinstitt@google.com, morbo@google.com, david.laight.linux@gmail.com Subject: Re: [PATCH v2] media: verisilicon: Replace strlcat() with scnprintf() Message-ID: References: <20261105084518.386234-1-nikitash.mariiaw@gmail.com> <20261111032446.29803-1-nikitash.mariiaw@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="beiyeemi46p27lup" Content-Disposition: inline In-Reply-To: <20261111032446.29803-1-nikitash.mariiaw@gmail.com> --beiyeemi46p27lup Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable From: Alejandro Colomar To: Mariia Nikitash Cc: nicolas.dufresne@collabora.com, benjamin.gaignard@collabora.com, p.zabel@pengutronix.de, mchehab@kernel.org, hverkuil+cisco@kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, kees@kernel.org, justinstitt@google.com, morbo@google.com, david.laight.linux@gmail.com Subject: Re: [PATCH v2] media: verisilicon: Replace strlcat() with scnprintf() Message-ID: References: <20261105084518.386234-1-nikitash.mariiaw@gmail.com> <20261111032446.29803-1-nikitash.mariiaw@gmail.com> MIME-Version: 1.0 In-Reply-To: <20261111032446.29803-1-nikitash.mariiaw@gmail.com> Hi Mariia, > Date: 2026-11-10 19:24:46-0800 > From: Mariia Nikitash > > In preparation for removing the deprecated strlcat() API [1], replace the > strscpy() and strlcat() calls in hantro_add_func() with a single > scnprintf() call. >=20 > This preserves the resulting string, including NUL termination > and truncation behavior. >=20 > Link: https://github.com/KSPP/linux/issues/370 [1] > Signed-off-by: Mariia Nikitash Reviewed-by: Alejandro Colomar Have a lovely day! Alex > --- > Changes in v2: > - Replace seq_buf with a single scnprintf() call, as suggested > by Hans Verkuil. >=20 > drivers/media/platform/verisilicon/hantro_drv.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/me= dia/platform/verisilicon/hantro_drv.c > index 26e5d5547466..d8854ceb4fed 100644 > --- a/drivers/media/platform/verisilicon/hantro_drv.c > +++ b/drivers/media/platform/verisilicon/hantro_drv.c > @@ -902,9 +902,8 @@ static int hantro_add_func(struct hantro_dev *vpu, un= signed int funcid) > vfd->vfl_dir =3D VFL_DIR_M2M; > vfd->device_caps =3D V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_M2M_MPLANE; > vfd->ioctl_ops =3D &hantro_ioctl_ops; > - strscpy(vfd->name, match->compatible, sizeof(vfd->name)); > - strlcat(vfd->name, funcid =3D=3D MEDIA_ENT_F_PROC_VIDEO_ENCODER ? > - "-enc" : "-dec", sizeof(vfd->name)); > + scnprintf(vfd->name, sizeof(vfd->name), "%s%s", match->compatible, > + funcid =3D=3D MEDIA_ENT_F_PROC_VIDEO_ENCODER ? "-enc" : "-dec"); > =20 > if (funcid =3D=3D MEDIA_ENT_F_PROC_VIDEO_ENCODER) { > vpu->encoder =3D func; > --=20 > 2.43.0 >=20 >=20 --=20 --beiyeemi46p27lup Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmr0RQUACgkQ64mZXMKQ wqmqRQ//REbcSjHBIDUOxJhm/720bIqOHJt+3DKA+HoHM0PTMB1GcDpZ0Cb1GFDz xRHYtg0O9h95qP0G/IoLsrZj3NkMamOmFu/Ofly9gLTOqQL1rz9owJ1CLhvmYd9I 8cWB/QtXkMiuQXlZJrNXDq2SByNEaJ4bsPjvvE77eID9cbp5ZTSUuz/T4BDE0kGV qI4XWwCmA7aKluSWJsM9Imr0WNtNVjxq4TF/HFG9H7XsqZOfX1nQAb9fAZUFFMaB 3w11l20mRk2vqfAG49JgcN5w+AwJ3Bt/xkBhHkylWG3KPherYIRq1PPXFF6QhxBo rw4Ybqo42Vb/EZfR4zVr10O/fFRwYveJTCrkT43f5gAChRNaa6N/WR5neV9/CoJk 5m4QyRrraxSx+l+loUZSINAa/N0AJemDBsFstXMakaO+/RzNe/QidFSURRxL+e4N 3mxIPmFGNR0EJcNf5rQscL2BJJI9DJMqfeIOS+M2zS1B4W58VUP4ccOpwg+mSBDJ qbQdnjTEWfWc8K0W/WC8OXcIAt53kwI3Vm8b4e3TUSYHoHOpwleImvVH8PDtXy9a OBfQO51X4evfcPbAgBSXe4WinWJmALl94hy9R3DhEwaLDP0VgWkb/pSC66goebpb Cbpqbegoxy8DO7Off0TR0a5KECKu5jQH6X9CiAFWA3DRXeZN0kw= =ogB2 -----END PGP SIGNATURE----- --beiyeemi46p27lup--