From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.14 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794417805; b=Br5Sg/hDXba/18otj9qdMAJTqYDmEyAiLPTGaehVKx+VmU1SvuSUs9AB1kE6TiVPV8ei wsccmSuoEaii5yDA1jibRXL8IYTQWbs0QEk5lo1ah+fAV49uaz7aovwSOv8biddBdDJ4K /S0ZwtVAZsCzyPYal9j8eqWk9vya7QFC/GLgxhk5FYlM/aLByqcF5bLM7hGKZCxndN5rC l3XFwTgT9RBL8FDevB0/AJ5WuJn006gFJsCS/e3yM+bQ8UmjTA/T8A9tKK3Mv+zP7F1p7 Ek1VVjt1tuvcOxF4ECMT0e2Vn4MsbXy3Z4hMkBGcGfNke+wYDmDOv+p0QC00uBxxB4Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794417805; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=Mc75NFpbRxzzIwWJ8CCnT2l1oCuJRiHbJaR6G/yXCvM=; b=sf6tmhoyCgLS/t8hMIAvoiMHvAJc5EnOxfnAA3wDHXutJIcy6PTMuSQ8A93dbKCYqhvx dwiEEPA0hDhgRYByIqmc3qb5Wrp61phD3fVBp0oYBwCGvEXlnXcfeLOdccYc7MKcrZuvc A/pjvaXGqB92mzjXjhy8sbyJfaEyKXx4e6iSWiqLLs+7F5DzjyYvXLQQ93FLtwHt8Z2KN mCf9vGDx+e5xPL/NZEntsDXe6tnKav0YmRMD2cX74786jEaAIGOuKZazNPJiETpph5vHc Hh7GDG1sBbgIbnRxndCDMQt+v49JwS0QC2u8/VcBUVt2zVOdDfLzdmcYxbVfddBJUuA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JE4TLWjA; arc=none smtp.remote-ip=192.198.163.14 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96C8F606A32A; Wed, 11 Nov 2026 17:23:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 96C8F606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=JE4TLWjA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1794417804; x=1825953804; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RZ0vaLA8sc1p8PfnxnpTBwN213VIpWvjXVmbbJQ2Xp0=; b=JE4TLWjAJBoMESyPufcU1ciE89V5yLRuF86y7VHEZpx7rWgfXEDJ1Ep6 F/3AO/0t8CyRZBk4dfmxkJHoNVUJ3EPg+ow168/szuevldCYqkp+6xKh9 fuhsJuzrb8NjKLDlaDm1FXiu4mTxz9SVRuJ0ndMT+NjX2xSN0UToW1J4b xQLyIQfD4mzM//tUz4TBUHwh/8RnjRMFXvDazvURV/zWR5eyYydm9baxP HS4cHlYtl+agfcHvNurocOVVGvL168axF9oTURHougdtubAoMceRVGlAE USZcb4htmTbxT27FrdVE8POcQ3HqK2RZzAaXjDwnw7qMDsKvyPjIlVu9C g==; X-CSE-ConnectionGUID: MNrxARglQK25rqcb7MmDow== X-CSE-MsgGUID: qyAfLKTUQE6GoswNw+Q2+A== X-IronPort-AV: E=McAfee;i="6800,10657,11963"; a="3225160" X-IronPort-AV: E=Sophos;i="6.27,208,1787036400"; d="scan'208";a="3225160" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2026 09:23:24 -0800 X-CSE-ConnectionGUID: /3mmSiG/TZif2qCOeBhiZg== X-CSE-MsgGUID: b6ZS1m5UTbW5pNkd/tOQpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,208,1787036400"; d="scan'208";a="8542441" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.47.46]) by orviesa001.jf.intel.com with ESMTP; 11 Nov 2026 09:23:21 -0800 Date: Thu, 12 Nov 2026 01:15:20 +0800 From: Xu Yilun To: Chao Gao Cc: "Edgecombe, Rick P" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "Van De Ven, Arjan" , "Xu, Yilun" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "kas@kernel.org" , "hpa@zytor.com" , "mingo@redhat.com" , "bp@alien8.de" , "tglx@kernel.org" Subject: Re: [RFC PATCH v2 1/2] x86/virt/seamldr: Support large TDX module binaries Message-ID: References: <20261106132159.1551365-1-chao.gao@intel.com> <20261106132159.1551365-2-chao.gao@intel.com> <0ee3d9592e4e73bd0e5bedafc836033fdfc9f120.camel@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > >> Thanks to Yilun for the idea of allocating the chain pages together > >> with 'struct seamldr_params'. > > > >I'm not sure what this means. > > I previously allocated the chained pages separately, as many as the module > needed, and linked them from 'struct seamldr_params'. Yilun suggested > growing 'struct seamldr_params' to include the chained pages, so a single > allocation covers both. > > I will credit Yilun with a Suggested-by tag. Thanks, but I think we drop it in next version to keep the tags simple. As the review goes on, more and more suggestions come, we don't record them all.