mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thorsten Blum <blum@kernel.org>
To: Paul Walmsley <pjw@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Deepak Gupta <debug@rivosinc.com>, Zong Li <zong.li@sifive.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	Zishun Yi <vulab@iscas.ac.cn>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: process: Use str_supported_unsupported() in compat_mode_detect()
Date: Wed, 11 Nov 2026 18:35:06 +0100	[thread overview]
Message-ID: <avSnSvPLqdkGWWYF@kernel.org> (raw)
In-Reply-To: <7d4e8a05-4e4e-55be-2a9d-715c65787c38@kernel.org>

Hi Paul,

On Thu, Oct 01, 2026 at 10:45:11AM -0600, Paul Walmsley wrote:
> On Tue, 29 Sep 2026, Thorsten Blum wrote:
> 
> > On Tue, Sep 29, 2026 at 11:11:55AM +0200, Geert Uytterhoeven wrote:
> > > Hi Paul, Thorsten,
> > > 
> > > On Sat, 26 Sept 2026 at 01:48, Paul Walmsley <pjw@kernel.org> wrote:
> > > > On Thu, 24 Sep 2026, Thorsten Blum wrote:
> > > > > Replace hard-coded strings with the str_supported_unsupported() helper.
> > > > > This unifies the output and helps the linker with deduplication, which
> > > > > can result in a smaller binary.
> > > > >
> > > > > Signed-off-by: Thorsten Blum <blum@kernel.org>
> > > >
> > > > Thanks, queued for v7.4.
> > > 
> > > Thanks for your patch, which is now commit a06776565b9e7351 ("riscv:
> > > process: Use str_supported_unsupported() in compat_mode_detect()")
> > > in riscv/for-next.
> > > 
> > > This fails to build:
> > > 
> > >     arch/riscv/kernel/process.c: In function ‘compat_mode_detect’:
> > >     arch/riscv/kernel/process.c:138:17: error: implicit declaration of
> > > function ‘str_supported_unsupported’
> > > [-Werror=implicit-function-declaration]
> > >       138 |                 str_supported_unsupported(compat_mode_supported));
> > >           |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > 
> > > as it has a hard dependency on commit 5383cf280ef4f00b
> > > ("lib/string_choices: Add str_supported_unsupported()
> > > helper"), which is only present in the for-next branch of
> > > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git.
> > 
> > Hi Geert,
> > 
> > It's also in linux-next:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=5383cf280ef4f00b15f1d9e2a2886d0d02c0118b
> 
> I'm dropping this one until the dependency lands in mainline.  

Do you want me to resend this patch now that the dependency [1] is in
mainline, or can you re-apply this one?

Thanks,
Thorsten

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ccd5ff410feb2adcf3840d071cf796cc5c549520

      reply	other threads:[~2026-11-11 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 21:32 Thorsten Blum
2026-09-25 23:48 ` Paul Walmsley
2026-09-29  9:11   ` Geert Uytterhoeven
2026-09-29  9:41     ` Thorsten Blum
2026-10-01 16:45       ` Paul Walmsley
2026-11-11 17:35         ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avSnSvPLqdkGWWYF@kernel.org \
    --to=blum@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=debug@rivosinc.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=vulab@iscas.ac.cn \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®