From: Brian Norris <briannorris@chromium.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
linux-pm@vger.kernel.org, "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
linux-kernel@vger.kernel.org,
"Jonathan Cameron" <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [PATCH v3] iio: gyro: bmg160: Discard pm_runtime_put_autosuspend() return values
Date: Wed, 11 Nov 2026 10:20:34 -0800 [thread overview]
Message-ID: <avSx8m0KegrXO8D4@google.com> (raw)
In-Reply-To: <auj9j3sbYa4sVoil@google.com>
Hi Jonathan,
On Mon, Nov 02, 2026 at 01:16:02PM -0800, Brian Norris wrote:
> On Mon, Nov 02, 2026 at 01:48:30AM +0000, Jonathan Cameron wrote:
> > --- a/drivers/iio/gyro/bmg160_core.c
> > +++ b/drivers/iio/gyro/bmg160_core.c
> > - data->ev_enable_state = state;
>
> This is an unexpected (to me) delta vs v2: you've stopped setting
> data->ev_enable_state here. I think that's a regression.
>
> This is also one reason I think it's unwise to make so many changes
> together here. One person's "churn" (to apply several patches to similar
> code) is another person's "hard to review / easy to make mistakes".
Gentle ping on this one. I'd like to advance my
pm_runtime_put_autosuspend() series one way or another. I'm willing to
respin this one for you if you'd like, even if I'm still personally
hesitant to make so many of these changes together.
I'm also open to going back to a minimal series -- that only drops the
return codes, and inlines functions that are trivial candidates.
Your call.
Brian
>
> > - mutex_unlock(&data->mutex);
> > + pm_runtime_put_autosuspend(dev);
> > + }
> >
> > return 0;
> > }
prev parent reply other threads:[~2026-11-11 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 1:48 Jonathan Cameron
2026-11-02 21:15 ` Brian Norris
2026-11-11 18:20 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avSx8m0KegrXO8D4@google.com \
--to=briannorris@chromium.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@oss.qualcomm.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®