From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.177 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794443118; b=nZTz2B/tDuAjIuVpC3MIU4OY0W7HZa0TYhtLxKza09t5BtFqbmDbsEfG94gcQ6VID+R6 GfZ7VJ8cjapdA0JZvn38+fmP7IwkEuLTPi4D7tmizYtN+nI/lK4Ozw9v4Mz9njOGL2N9b iR+c15l662sK02BDgcjvtwg6Ip5ektDZuTwrlrJFNUOUni3m2rxJQdK7CzcfmlkLl4hJq SHPUHJNQ5Jxw4XXsmxf7Ctekz3FMdCs1wUzOgMLVb+CuPB1YY2ilihisb360NJirUZ1p9 lXxR9m8xp5fHMiGdJq2UWCQTkbCj5wCblBG+8pMEklKK/udH8gek8rUWRD9NBA8vznQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794443118; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=WmDxcQotq3NgeobvzOlqzwVczvRUhsveENxWAqE5LCM=; b=Wizwl3QpanjTF4pCsEGoyrtJ2iWDnwqanzZMp08cdKBv1KNr+ggN09CgkwTk/O6PCJab aUH/A9KETmRJ1Nsa9p5kN4dMFfApFi0/9ag3rTkSyVVJiVRGjbcYB7MhOgbKeySCwmnaJ GYhRZCh0b3jU3oyOmbpYBsbTdJTgWydkZqFanbXsIO/zpHGdKQEa/bSiNdt6ahAROKG37 cKOGzlXpuuhrOdkthqHFMmW2w1J7QU/lfZCx59WZoxYCuFsO+D2hiItDbdJHJdzaFXNZS GnZ973jf31pEbQDeaD4Vb2w1/n+EUxqeJAXTparafBxo8h00Lf9mMAEmqxjK9lJC4KQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="h1S/DtRe"; arc=none smtp.remote-ip=74.125.82.177 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB64606A324 for ; Thu, 12 Nov 2026 00:25:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6BB64606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=h1S/DtRe Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-37071c0f42aso6358081eec.0 for ; Wed, 11 Nov 2026 16:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794443117; x=1795047917; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WmDxcQotq3NgeobvzOlqzwVczvRUhsveENxWAqE5LCM=; b=h1S/DtReSrooUG+5tSN0w/2VC4kQ8AWHjCfF28Z9OQxDnt2zBOzOG5sKY0JnQnJnFJ zNwQbHhUCOB+mBz+KNl0PE8STaFR26KMtp9vkTpW7C07Cb/YyzjGHtqM07sjuYKHxOVT Bw6BOYKRKl4LpOTyraYV/EqXqZQE0emqlHIbes5FFn1qm34+50N3/YHSvLdJ19ytxeVE 6yPp0kLgJnc0+ca3K6gduebk0nEVB67S9ZCzo6eMWtcjuyTSxgk/QI0JxuJsNwK89sRJ srUy5gRBPksXx3Vl0TSo+9xqOGXIDjeVqvcLE+cpxfsKW8sza5a3MUFK7cLr+uKfTsYC 9a4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794443117; x=1795047917; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WmDxcQotq3NgeobvzOlqzwVczvRUhsveENxWAqE5LCM=; b=w0aCdWLxx1YgGVLCvh5DZtf+BPK2zf1fgX1bfvJvJJ8ZfRYf6lGgUQcD41CZiruixh rmlFV4KfTLhjrGNEoPpt5tZzdEzRC9bkbkmaDd3VXQKshIBS03XLlRYwiixQVE+NE6S1 xJ7i/7IIriG2TXGzSG2Zh8JA7LagXDEx6wFTYXe9CLror2swf58ybsn/yssfnMEe/bVM qghBtlzb3WPd+MIDumi+nUFtVJBnPsN8t6quieHqIMN8A32y5huVtF4yhIczLEbmyg4Q lomagerKOxthIPVOFq6iM+K8k/4V0K89kynsfk6IykLRYBDXHD1UghxaSBIU+nF5Tg0Y wZjA== X-Forwarded-Encrypted: i=1; AL+hErE4WiNcL0A3iB9n8el3/ufbZo6ireHabJsSNg68eemci4VWpiEdSpAgXUJEMpSX/0XL2Yd2Uu9bDegqnyE=@vger.kernel.org X-Gm-Message-State: APuU4Z9QEghF0j8YzLI8cAJfzfnfjxyqvU2nYRe+YMCeEkZbjUhCOKDL 0ZoK5gDnnHIVu2CgQP0RCMoCE/Jolk/YYel5GaBx1zs+HRnWDMw0YsT5 X-Gm-Gg: AYBFou3f9bdq28qy3QGQxE6zYGmuXyexXVBWheTCI5sNxSmk2ui+CS0s15U7euXfUlH LrzWzX7Mdernag9dUCj2s4DFogd/duUd97rE0KpLZ/6P9jR80wRbNwMK58WUvt7OyfCbXmcmUz6 sr/3X/5eBLTj0SXCtPnOiswyJimytSET9hrNj2FRNVPE0z1+wELMGvqFwlem0n+m0KTc/UKZ0NA lb/9RtcmeGLwhLXyQOwlGOmyd+l3ErCW5O18dn2iVplQ09iqjC7C2JbxqInG26jHBwbO3ga0Nl+ oO1UCQ4ZkA0bk6+xYvpVtq1a89kWNeMcWgfh2iCYrH/kcRWvd8xAC6YQkhEnR0mQu6LIUIBtOOO 0jD3mAEYi822MToDKRnTzIbQeLrNGlcAQTFUfvpg6rjDHRlJkqPTGDwgKKgkIfGBXGXmL4OQ0fm WzgNWipHF00J38No9DVTj2G38WwEOW0IbchSYRHrGuhr8zpS/SmKBQoDH256N/fDnvUF6eSJucJ VitYlbj3q396MJr9hrH3gfG8BveDlxazy/LsPeAWftMXJdaxecMDVGVsHucJ9aFpOpHvNNFi7Un rEPTIOkt9CbxeFicU9/jMOseGbieBqEFbtuEUX5+fo6yL/DuL7VaMEVnO1ySpegaD0tJ6A== X-Received: by 2002:a05:7301:d807:b0:378:2e89:3958 with SMTP id 5a478bee46e88-3782e893b15mr345363eec.19.1794443117438; Wed, 11 Nov 2026 16:25:17 -0800 (PST) Received: from google.com ([2a00:79e0:2ebe:8:182d:659:ffce:39a4]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3766146551asm12082193eec.1.2026.11.11.16.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2026 16:25:15 -0800 (PST) Date: Wed, 11 Nov 2026 16:25:11 -0800 From: Dmitry Torokhov To: Jakob Unterwurzacher , "Rafael J. Wysocki" , Tony Lindgren Cc: Joseph Chen , Lee Jones , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, mfd@lists.linux.dev, devicetree@vger.kernel.org, Jakob Unterwurzacher Subject: Re: [PATCH 1/4] Input: rk805-pwrkey - enable the wakeup interrupt during system suspend Message-ID: References: <20261029-dev-tiger-v7-4-pre-20261028-tiger-suspend-b4-v1-0-cb12621c1fb4@cherry.de> <20261029-dev-tiger-v7-4-pre-20261028-tiger-suspend-b4-v1-1-cb12621c1fb4@cherry.de> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261029-dev-tiger-v7-4-pre-20261028-tiger-suspend-b4-v1-1-cb12621c1fb4@cherry.de> Hi Jakob, On Thu, Oct 29, 2026 at 11:06:23AM +0100, Jakob Unterwurzacher wrote: > From: Jakob Unterwurzacher > > The driver marks the device as wakeup capable, but never enables the > power key interrupt as a wakeup interrupt. As a consequence, the PMIC > interrupt line is masked during system suspend and the power key cannot > wake up the system, e.g. from suspend-to-ram on RK3588 with an RK806. > > Enable the interrupt as wakeup interrupt in the suspend callback if the > device may wake up the system, and disable it again on resume. > > This is done in the regular suspend phase on purpose, rather than with > dev_pm_set_wake_irq(), which arms the wakeup in the noirq phase: there, > enabling it updates the PMIC's interrupt registers through regmap-irq, > which fails when the PMIC is connected via SPI: > > spi_master spi2: Failed to power device: -13 > rk8xx-spi spi2.0: Failed to sync masks in 7a Sounds like this needs to be solved in PM core rather than hacked around in individual driver? Let's CC Tony and Rafael. > > Fixes: 5a35b85c2d92 ("Input: add power key driver for Rockchip RK805 PMIC") > --- > drivers/input/misc/rk805-pwrkey.c | 42 ++++++++++++++++++++++++++++++++++++++- > 1 file changed, 41 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/misc/rk805-pwrkey.c b/drivers/input/misc/rk805-pwrkey.c > index 76873aa005b41..9b64ec7463c62 100644 > --- a/drivers/input/misc/rk805-pwrkey.c > +++ b/drivers/input/misc/rk805-pwrkey.c > @@ -15,6 +15,10 @@ > #include > #include > > +struct rk805_pwrkey { > + int irq; > +}; > + > static irqreturn_t pwrkey_fall_irq(int irq, void *_pwr) > { > struct input_dev *pwr = _pwr; > @@ -37,10 +41,15 @@ static irqreturn_t pwrkey_rise_irq(int irq, void *_pwr) > > static int rk805_pwrkey_probe(struct platform_device *pdev) > { > + struct rk805_pwrkey *priv; > struct input_dev *pwr; > int fall_irq, rise_irq; > int err; > > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > pwr = devm_input_allocate_device(&pdev->dev); > if (!pwr) { > dev_err(&pdev->dev, "Can't allocate power button\n"); > @@ -84,16 +93,47 @@ static int rk805_pwrkey_probe(struct platform_device *pdev) > return err; > } > > - platform_set_drvdata(pdev, pwr); > + priv->irq = fall_irq; > + platform_set_drvdata(pdev, priv); > device_init_wakeup(&pdev->dev, true); > > return 0; > } > > +/* > + * Arm the wakeup in the regular suspend phase rather than with > + * dev_pm_set_wake_irq(), which does it in the noirq phase: enabling the > + * wakeup updates the PMIC's interrupt registers, which is no longer > + * possible once the bus to the PMIC (e.g. SPI on RK806) is suspended. > + */ > +static int rk805_pwrkey_suspend(struct device *dev) > +{ > + struct rk805_pwrkey *priv = dev_get_drvdata(dev); > + > + if (device_may_wakeup(dev)) > + enable_irq_wake(priv->irq); > + > + return 0; > +} > + > +static int rk805_pwrkey_resume(struct device *dev) > +{ > + struct rk805_pwrkey *priv = dev_get_drvdata(dev); > + > + if (device_may_wakeup(dev)) > + disable_irq_wake(priv->irq); > + > + return 0; > +} > + > +static DEFINE_SIMPLE_DEV_PM_OPS(rk805_pwrkey_pm_ops, rk805_pwrkey_suspend, > + rk805_pwrkey_resume); > + > static struct platform_driver rk805_pwrkey_driver = { > .probe = rk805_pwrkey_probe, > .driver = { > .name = "rk805-pwrkey", > + .pm = pm_sleep_ptr(&rk805_pwrkey_pm_ops), > }, > }; > module_platform_driver(rk805_pwrkey_driver); > Thanks. -- Dmitry