mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Oleg Nesterov <oleg@redhat.com>, akpm@linux-foundation.org
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
	 Nicholas Piggin <npiggin@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, kernel-team@meta.com,
	 syzbot+8fdf0d8e10bdde1c2e88@syzkaller.appspotmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] reboot: halt when power off fails
Date: Thu, 12 Nov 2026 01:33:22 -0800	[thread overview]
Message-ID: <avWGu4l_nXP_eFyh@gmail.com> (raw)
In-Reply-To: <avTJ3o-n0UZS0YUj@redhat.com>

On Wed, Nov 11, 2026 at 09:02:38PM +0100, Oleg Nesterov wrote:
> On 11/10, Breno Leitao wrote:
> >
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -791,6 +791,9 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
> >
> >  	case LINUX_REBOOT_CMD_POWER_OFF:
> >  		kernel_power_off();
> > +		pr_emerg("Power off failed: System halted instead\n");
> > +		/* kernel_power_off() already ran the shutdown, only halt. */
> > +		machine_halt();
> 
> Agreed. Even if I don't think my ack has any value in this area:

Thanks, Oleg.

I tried to find out who merges changes to this file and it is not clear.
akpm seems to be the closest, as most of the changes went through him,
and somehow he was not CCed here. :-|

Andrew, would you be willing to take this one?

thanks,
--breno

      reply	other threads:[~2026-11-12  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:24 Breno Leitao
2026-11-10 15:50 ` Bradley Morgan
2026-11-11 20:02 ` Oleg Nesterov
2026-11-12  9:33   ` Breno Leitao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avWGu4l_nXP_eFyh@gmail.com \
    --to=leitao@debian.org \
    --cc=akpm@linux-foundation.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=ebiederm@xmission.com \
    --cc=kernel-team@meta.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+8fdf0d8e10bdde1c2e88@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®