mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Fabio Estevam <festevam@gmail.com>
Cc: horia.geanta@nxp.com, pankaj.gupta@nxp.com,
	sahil.malhotra@nxp.com, gaurav.jain@nxp.com,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Fabio Estevam <festevam@nabladev.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] crypto: caam: jr: Use dedicated shutdown callback
Date: Thu, 12 Nov 2026 18:05:22 +0800	[thread overview]
Message-ID: <avWPYp6fA_Y5pgCq@gondor.apana.org.au> (raw)
In-Reply-To: <20261028132825.657546-1-festevam@gmail.com>

On Wed, Oct 28, 2026 at 10:28:25AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@nabladev.com>
> 
> The CAAM job ring platform driver uses caam_jr_remove() as its
> shutdown callback.
> 
> The remove path refuses to shut down a job ring while crypto
> consumers still hold references to it. This is necessary during
> driver unbinding, but causes the following warning on reboot:
> 
> caam_jr 30903000.jr: Device is busy; consumers might start to crash
> 
> Unlike driver removal, system shutdown does not require
> unregistering crypto algorithms or releasing driver resources.
> 
> Introduce a dedicated platform shutdown callback that shuts down
> the hardware job ring without checking consumer references.
> 
> Keep the reference checks and algorithm unregistration in the
> remove path.
> 
> Tested on a i.MX8MP custom-board.
> 
> Cc: stable@vger.kernel.org 
> Fixes: c007e720989e ("crypto: caam/jr - add .shutdown hook")
> Signed-off-by: Fabio Estevam <festevam@nabladev.com>
> ---
>  drivers/crypto/caam/jr.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2026-11-12 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:28 Fabio Estevam
2026-11-12 10:05 ` Herbert Xu [this message]
2026-11-12 10:41 ` Sahil Malhotra
2026-11-12 11:48   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avWPYp6fA_Y5pgCq@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=festevam@gmail.com \
    --cc=festevam@nabladev.com \
    --cc=gaurav.jain@nxp.com \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pankaj.gupta@nxp.com \
    --cc=sahil.malhotra@nxp.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®