From: Herbert Xu <herbert@gondor.apana.org.au>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Hadar Gat <hadar.gat@arm.com>,
Olivia Mackall <olivia@selenic.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwrng: cctrng - fix usage counter in error path
Date: Thu, 12 Nov 2026 18:16:38 +0800 [thread overview]
Message-ID: <avWSBrBQLBA0MwBJ@gondor.apana.org.au> (raw)
In-Reply-To: <20261031144729.2327464-1-martin@kaiser.cx>
On Sat, Oct 31, 2026 at 03:46:20PM +0100, Martin Kaiser wrote:
> If probe fails after the runtime pm usage counter was incremented,
> we have to decrement it before we exit.
>
> Remove the cc_trng_pm_fini call in the error path. It calls
> pm_runtime_disable before runtime pm is enabled.
>
> Fixes: a583ed310bb6 ("hwrng: cctrng - introduce Arm CryptoCell driver")
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> based on sashiko review
> https://lore.kernel.org/linux-crypto/67844d9d-d4d4-4026-9549-73589afcc1ff@wanadoo.fr/T/#m1a770f5f9eeed95b48cad7545580aed4fa74e6fa
>
> compile-tested only
>
> v2:
> - don't duplicate the error code in dev_err_probe
>
> drivers/char/hw_random/cctrng.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-11-12 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 14:46 Martin Kaiser
2026-11-12 10:16 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avWSBrBQLBA0MwBJ@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hadar.gat@arm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®