From: Mel Gorman <mgorman@techsingularity.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Seiji Nishikawa <snishika@redhat.com>,
Mian Yousaf Kaukab <ykaukab@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] sched/rt: Do not account migrate-disabled tasks as pushable
Date: Thu, 12 Nov 2026 11:38:10 +0000 [thread overview]
Message-ID: <avWg-7PFyaHmcyRL@techsingularity.net> (raw)
In-Reply-To: <20261112044642.0f28f038@fedora>
On Thu, Nov 12, 2026 at 04:46:42AM -0500, Steven Rostedt wrote:
> On Tue, 10 Nov 2026 23:20:55 +0000
> Mel Gorman <mgorman@techsingularity.net> wrote:
>
> > -stable warning: This patch is part of a series and applying just this
> > patch on its own breaks the !RT_PUSH_IPI case.
>
> I don't see why this is 3 patches. It looks like patch 2 and 3 could be
> folded into this one.
>
Accident of history mostly and preserving the fact I wasn't the code author
of the first patch and I played it safe. 2 was initially "reduce risk of
drift if only 1 caller is updated in the future" and by co-incidence made
patch 3 fractionally easier. 3 was written later while checking for any
side-effects of the fix -- namely the !RT_PUSH_IPI is degraded by some
unquantifed and unnecessary factor. That's ok justification but 2-3 are
not complex enough to justify the risk and Yousaf has no objection to
collapsing them.
I'll collapse them into 1.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2026-11-12 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 23:20 [PATCH 0/3] Reduce spurious RT_PUSH_IPI storms Mel Gorman
2026-11-10 23:20 ` [PATCH 1/3] sched/rt: Do not account migrate-disabled tasks as pushable Mel Gorman
2026-11-12 9:46 ` Steven Rostedt
2026-11-12 11:38 ` Mel Gorman [this message]
2026-11-10 23:20 ` [PATCH 2/3] sched/rt: Check eligibility of pushable task in one place Mel Gorman
2026-11-10 23:20 ` [PATCH 3/3] sched/rt: Treat migrate-disabled tasks as pushable if RT_PUSH_IPI is disabled Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avWg-7PFyaHmcyRL@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=snishika@redhat.com \
--cc=vincent.guittot@linaro.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®