From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Usama Arif <usama.arif@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
apopple@nvidia.com, byungchul@sk.com, gourry@gourry.net,
jannh@google.com, joshua.hahnjy@gmail.com, liam@infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, matthew.brost@intel.com, mhocko@suse.com,
pfalcato@suse.de, rppt@kernel.org, surenb@google.com,
vbabka@kernel.org, ying.huang@linux.alibaba.com, ziy@nvidia.com,
kas@kernel.org, hannes@cmpxchg.org, riel@surriel.com,
shakeel.butt@linux.dev, kernel-team@meta.com,
baolin.wang@linux.alibaba.com, Nico Pache <nico.pache@linux.dev>,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
lance.yang@linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: don't PTE-batch a swap-in over a hardware-poisoned subpage
Date: Thu, 12 Nov 2026 11:54:11 +0000 [thread overview]
Message-ID: <avWouX4hCmAz9F4p@gremlin> (raw)
In-Reply-To: <d74a277f-f14c-436d-868f-2566d90bc144@kernel.org>
On Thu, Nov 12, 2026 at 09:56:39AM +0100, David Hildenbrand (Arm) wrote:
> On 11/11/26 14:18, Lorenzo Stoakes (ARM) wrote:
> > Hm, isn't scanning every single page in the folio potentially quite costly
> > here? I thought the point of batching was to improve performance overall?
>
> Yeah, we don't really want another helper to check for hwpoison.
>
> If we race with concurrent hwpoison, bad luck. The slapped on memory-failure
> code is full of races. That needs a proper long-term solution, not more pain to
> core-mm.
Yeah exactly. See Usama's reply - it really does narrow into a weird edge
case. Scan there if you want to scan at all.
Otherwise tough luck yes.
>
> So let's please try reusing existing helpers that test the large-folio bit.
Yes please!
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-11-12 11:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 11:38 [PATCH 0/3] mm: fixes for THP migration, swap-in and device-private smaps Usama Arif
2026-11-11 11:38 ` [PATCH 1/3] mm: don't PTE-batch a swap-in over a hardware-poisoned subpage Usama Arif
2026-11-11 13:18 ` Lorenzo Stoakes (ARM)
2026-11-11 18:39 ` Usama Arif
2026-11-12 11:52 ` Lorenzo Stoakes (ARM)
2026-11-12 8:56 ` David Hildenbrand (Arm)
2026-11-12 11:54 ` Lorenzo Stoakes (ARM) [this message]
2026-11-11 18:50 ` Zi Yan
2026-11-11 11:38 ` [PATCH 2/3] fs/proc/task_mmu: don't read young/dirty from a non-present PMD in smaps Usama Arif
2026-11-11 13:27 ` Lorenzo Stoakes (ARM)
2026-11-12 7:40 ` Baolin Wang
2026-11-12 8:57 ` David Hildenbrand (Arm)
2026-11-11 11:38 ` [PATCH 3/3] fs/proc/task_mmu: account device-private PMDs as present " Usama Arif
2026-11-11 13:30 ` Lorenzo Stoakes (ARM)
2026-11-12 9:00 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avWouX4hCmAz9F4p@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=nico.pache@linux.dev \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®