From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.218.50 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794508436; b=MaHMF4u3gAz2CerLiBeHz1DgVw3C28Cy/EgMPJnGG3aIcX9gO9mHclDq+OJXLwv2LVi7 IZryi5erQpr61gRodqjI85rNSDkjqaU8Zhw7OjcXxXw40oXnovIQ1p0wPMjdgOpnyMqe3 GcyMngLW3J09zUF3yBVj0YOBDHRL5VgZzZQvsXmftOmIR28htIhX+uYVax7JCLQ2bNoM7 tB4d0GcQHNEa0yf7sE4ejW0oq0Pq4lpnAw53Au46JjMQRZXOtBy0hwgCG43bSD3QKSRXw yoqvlxbwryi6YM4MmvtJwJiWPfozQHPM6lUzomzXDNaFRfejgJMdgWmObr8W3kwfDtw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794508436; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:X-Google-Original-From:Date:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=0T59pX0NBuc6eb0M//aPEdCc6M8d0Cv25oKr0gLdXm4=; b=i1RZlRn18iY3RuCDBlqLxqqNSgnTy79LLsSygYVhPfcrViwGJoBUWLri2Xln2XS7Ct2m KN29H/wcqR1vylu1l/Gwl9jp8WWT9YCt+FuAZ301K/1OcU2a2simojERLA0jIyivJvf+9 ASob4EhnmPXrTwS5/8ighz280rmcF/6Vu7wIrrZc48gapYA1wp7eUaYYvDzr1DrV4yFLX T6SG/lWE5DRCY8UYCXwVX0woWGJg8Em3hJ4oqEBR/ll7/gtThZ84PRiJNBrY5N20pwJ9P 2Q5j3WPdYxukr4xp77qUrbKsZy50+RF7gJtUPDNuJpKz/sxh/1VXiBCo+vs+0N8CkvA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=imxi032c; arc=none smtp.remote-ip=209.85.218.50 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5EC606A893 for ; Thu, 12 Nov 2026 18:33:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1A5EC606A893 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=imxi032c Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-c4c9abc1824so7157966b.1 for ; Thu, 12 Nov 2026 10:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794508434; x=1795113234; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0T59pX0NBuc6eb0M//aPEdCc6M8d0Cv25oKr0gLdXm4=; b=imxi032cS0x76ZjKJFrnJjVcpa4j/RetctXMOzH/RAoNujK81/PGf3OD9XVYf06OD1 vMOvSOHUE1wes4tjT1uZAJSvdzXng96OWh7uXcoizRID5Qg974oCg9DJKqHlfSgvn0yB HHIrjDSMWAnaoz6IMUo/apC7uFmgXX5uqLfubomxF6t6a6FERmpTCCxABUYjEawULXD8 klCWqBM5uZl2TzEOtDF8+awi/vDwXsGP9mrDUvkQ3x3dvy2DALPta8aXV3ALMPfppqQt QWVUBf5h/qbYDOLqSp+D8Q1sgXktGZ452oL3iWWjvUjnOjMKtiaDUjnMGMQH8PY1ThWJ yVMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794508434; x=1795113234; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0T59pX0NBuc6eb0M//aPEdCc6M8d0Cv25oKr0gLdXm4=; b=TnGQnkTtT/x7HTE88vmeT/IXQU3P+ASzz/7R1XTqcVt/+xIAcH3Jt+UDBnQUihdgNw NLZ+JAFEek8JFq+kutOlhC0DImZA86a8G9OW62yjxt+NJPOS44PgjOMf6xlkr6npxtP3 Qxahfd5YT1F8zii6rANRCXpgg2JD+gtQrDagEnJxhtajAU3BfJhhaLanA8wjtc2FjIt7 e6Z1CMwFVfaOvRPOuz3tU9aN+HLKKNCCVh801zIcqJNKMII4RdhMxlM6k0ybJfA5loQy wencYq2TJP6WZ0nGZmX20W92azJhOxe5RzPOWbQufqRCJeO7U5zHWDTJGMq6/WkyyCty Vcjw== X-Forwarded-Encrypted: i=1; AL+hErEB2ejh7ZkL0mm0kXjTzBQGDYkGLFPVsu0ENLjat5AJNXWGT1Ri1BxiWGMpdKbjMU7XDEkkH2xaVxpQ6Zs=@vger.kernel.org X-Gm-Message-State: APuU4Z9BMILk0DNQDRO68VJlhA1KXCAuI2iWQ/mAiwATg2K8TJBqwUw1 T90pvDKg3/V5b3DpnfunFwMwWhX7jRVq7eXSWC/5w2jq8dM2n5j1s1Is X-Gm-Gg: AYBFou2i6lp8Y9iO4wx0shSf2t3txbSyY/HF5Q+VnF7X64RytJvQ3fP2L0A2yalqUtw XC684B1QcuD79EuWdSoRIaNCE9M7dCj49ySksVENXMz4gKUfyijM8JXxZwpHKRW39674VRYmlmT Xw+Vk0GMcaKO1gSSv8vdJ71duab5a9KhivHUbMB826VT9IYFpFjb0NlC4XIHx5Wkey/y/XBBB1U bOejbFfu6lORbm7QPkjA4kV8LeWToRZZOdyr9EptGfzImfPoXyJ/gYZsA4AYgMzSfv1RtuWPflp 582+oqV7T2yb67VLPwWhruUD2ebzZvCnlLez9UWs0l+pKfu65WNEL2356qDpIsJ6bOAHb7LrlZI bc/dduc5Fzz0xN8Fp0GUiCurG7COpcLL59qN1HhshL+XEL2FTLf7na0OdjSSO33YV0aM9KD8IQg RWsLqcFa29wkc2669KIm1EAfbGNPCJsvGC3RcGHy53F0dPgWCnrBB89PYiDHiIbJH9ycxSzwZ7v 0K0ABpGPQr4sXUQn+j9B1JEbCxoPJvvE2onXgcSnB7JEF9yyTjCvMQ2RudaCATIx3+IFuEn9Jd7 Stl6b1X+9YIN71MT X-Received: by 2002:a17:907:6d08:b0:c34:e9fe:82ed with SMTP id a640c23a62f3a-c50963d803amr9289866b.28.1794508434209; Thu, 12 Nov 2026 10:33:54 -0800 (PST) Received: from krava ([173.38.220.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c5095b236edsm6328666b.23.2026.11.12.10.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 10:33:53 -0800 (PST) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Thu, 12 Nov 2026 19:33:51 +0100 To: Peter Zijlstra Cc: Masami Hiramatsu , Naveen N Rao , "David S. Miller" , Josh Poimboeuf , Jason Baron , Alice Ryhl , Steven Rostedt , Ard Biesheuvel , Thomas Gleixner , Ingo Molnar , Alan Maguire , x86@kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 03/13] jump_label/x86: Avoid decoding instructions for jump entry size Message-ID: References: <20261109194916.1089703-1-jolsa@kernel.org> <20261109194916.1089703-4-jolsa@kernel.org> <20261112083945.GF2668804@noisy.programming.kicks-ass.net> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261112083945.GF2668804@noisy.programming.kicks-ass.net> On Thu, Nov 12, 2026 at 09:39:45AM +0100, Peter Zijlstra wrote: > On Mon, Nov 09, 2026 at 08:49:06PM +0100, Jiri Olsa wrote: > > > int arch_jump_entry_size(struct jump_entry *entry) > > { > > + const u8 *code = (void *)jump_entry_code(entry); > > > > + if (code[0] == JMP8_INSN_OPCODE || > > + !memcmp(code, x86_nops[JMP8_INSN_SIZE], JMP8_INSN_SIZE)) > > + return JMP8_INSN_SIZE; > > > > + if (code[0] == JMP32_INSN_OPCODE || > > + !memcmp(code, x86_nops[JMP32_INSN_SIZE], JMP32_INSN_SIZE)) > > + return JMP32_INSN_SIZE; > > + > > + BUG(); > > } > > Does this actually generate sane code and checks code[0] first for both > values before it goes and does memcmp() ? The naive translation would > suggest it does not. > nope.. you're right, I'll make it explicit thanks, jirka