On Wed, Aug 26, 2026 at 11:48:41AM +0200, Herve Codina wrote:
> Add tests related to external phandle references used in
> properties (FDT_PROPDATA_PHANDLE_REF dtb tag).
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

As with other patches, these tests look valuable, but I'm not thrilled
with the text diffs.

> ---
>  ...etadata_propdata_phandle_ref.dtb.dts.expect | 18 ++++++++++++++++++
>  tests/metadata_propdata_phandle_ref.dtb.expect | 16 ++++++++++++++++
>  tests/metadata_propdata_phandle_ref.dts        | 11 +++++++++++
>  ...etadata_propdata_phandle_ref.dts.dts.expect | 18 ++++++++++++++++++
>  tests/run_tests.sh                             |  2 +-
>  5 files changed, 64 insertions(+), 1 deletion(-)
>  create mode 100644 tests/metadata_propdata_phandle_ref.dtb.dts.expect
>  create mode 100644 tests/metadata_propdata_phandle_ref.dtb.expect
>  create mode 100644 tests/metadata_propdata_phandle_ref.dts
>  create mode 100644 tests/metadata_propdata_phandle_ref.dts.dts.expect
> 
> diff --git a/tests/metadata_propdata_phandle_ref.dtb.dts.expect b/tests/metadata_propdata_phandle_ref.dtb.dts.expect
> new file mode 100644
> index 00000000..61ce943b
> --- /dev/null
> +++ b/tests/metadata_propdata_phandle_ref.dtb.dts.expect
> @@ -0,0 +1,18 @@
> +/dts-v1/;
> +/plugin/;
> +
> +/ {
> +
> +	fragment@0 {
> +		target = <&test>;
> +
> +		__overlay__ {
> +			ref = <&node_a>;
> +		};
> +	};
> +
> +	__fixups__ {
> +		test = "/fragment@0:target:0";
> +		node_a = "/fragment@0/__overlay__:ref:0";
> +	};
> +};
> diff --git a/tests/metadata_propdata_phandle_ref.dtb.expect b/tests/metadata_propdata_phandle_ref.dtb.expect
> new file mode 100644
> index 00000000..f79f542d
> --- /dev/null
> +++ b/tests/metadata_propdata_phandle_ref.dtb.expect
> @@ -0,0 +1,16 @@
> +/dts-v1/;
> +
> +/ {
> +    fragment@0 {
> +        target = <0xffffffff>;
> +        // [FDT_PROPDATA_PHANDLE_REF] target[0], ref = test
> +        __overlay__ {
> +            ref = <0xffffffff>;
> +            // [FDT_PROPDATA_PHANDLE_REF] ref[0], ref = node_a
> +        };
> +    };
> +    __fixups__ {
> +        test = "/fragment@0:target:0";
> +        node_a = "/fragment@0/__overlay__:ref:0";
> +    };
> +};
> diff --git a/tests/metadata_propdata_phandle_ref.dts b/tests/metadata_propdata_phandle_ref.dts
> new file mode 100644
> index 00000000..b8aa6509
> --- /dev/null
> +++ b/tests/metadata_propdata_phandle_ref.dts
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +/*
> + * Copyright (C) 2026 Bootlin
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&test {
> +	ref = <&node_a>;
> +};
> diff --git a/tests/metadata_propdata_phandle_ref.dts.dts.expect b/tests/metadata_propdata_phandle_ref.dts.dts.expect
> new file mode 100644
> index 00000000..61ce943b
> --- /dev/null
> +++ b/tests/metadata_propdata_phandle_ref.dts.dts.expect
> @@ -0,0 +1,18 @@
> +/dts-v1/;
> +/plugin/;
> +
> +/ {
> +
> +	fragment@0 {
> +		target = <&test>;
> +
> +		__overlay__ {
> +			ref = <&node_a>;
> +		};
> +	};
> +
> +	__fixups__ {
> +		test = "/fragment@0:target:0";
> +		node_a = "/fragment@0/__overlay__:ref:0";
> +	};
> +};
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index 8c27b463..f5ea02bf 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -1240,7 +1240,7 @@ fdtoverlay_tests() {
>  }
>  
>  metadata_tests() {
> -	for dt in metadata_propdata_phandle_local; do
> +	for dt in metadata_propdata_phandle_local metadata_propdata_phandle_ref; do
>  		run_dtc_test -I dts -O dts -o $dt.dts.dts "$SRCDIR/$dt.dts"
>  		base_run_test check_diff $dt.dts.dts "$SRCDIR/$dt.dts.dts.expect"
>  		run_dtc_test -I dts -O dtb -o $dt.dtb "$SRCDIR/$dt.dts"
> -- 
> 2.55.0
> 
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson