From: Steffen Klassert <steffen.klassert@secunet.com>
To: "Jérémy Jean" <jeremy.jean@oss.cyber.gouv.fr>
Cc: Florian Westphal <fw@strlen.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH net v4 2/2] xfrm: fix selector matching for IPv6 atomic fragments
Date: Fri, 13 Nov 2026 11:53:11 +0100 [thread overview]
Message-ID: <avbsF2Fmc2G4Nztg@gauss4> (raw)
In-Reply-To: <4231ca089dfd7e7ec42d85f9e72ac535@oss.cyber.gouv.fr>
On Thu, Nov 12, 2026 at 02:33:35PM +0100, Jérémy Jean wrote:
> On 2026-11-12 14:20, Florian Westphal wrote:
> > Jérémy Jean <Jeremy.Jean@oss.cyber.gouv.fr> wrote:
> > > + if ((flkeys.control.flags & FLOW_DIS_IS_FRAGMENT) &&
> > > + ipv6_find_hdr(skb, &offset, -1, NULL, &fh_flags) >= 0 &&
> > > + (fh_flags & IP6_FH_F_FRAG) &&
> > > + !(fh_flags & IP6_FH_F_NON_ATOMIC)) {
> >
> > Since you need to send a new version anyway, maybe avoid
> > double-neg, i.e.: (fh_flags & IP6_FH_F_ATOMIC) ?
>
> Thanks for the advice, I will consider this for the next iteration.
When resending, please make sure to also Cc the new ipsec mailing list
so that the ipsec patchwork can track it:
ipsec@lists.linux.dev
Thanks!
next prev parent reply other threads:[~2026-11-13 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 21:38 [PATCH net v4 0/2] xfrm: fix IPv6 atomic fragment policy handling Jérémy Jean
2026-11-09 21:38 ` [PATCH net v4 1/2] xfrm: fix IPv6 first-fragment protocol decode Jérémy Jean
2026-11-09 21:38 ` [PATCH net v4 2/2] xfrm: fix selector matching for IPv6 atomic fragments Jérémy Jean
2026-11-12 12:39 ` netdev-bot+sashiko
2026-11-12 13:20 ` Florian Westphal
2026-11-12 13:33 ` Jérémy Jean
2026-11-13 10:53 ` Steffen Klassert [this message]
2026-11-09 22:56 ` [PATCH net v4 0/2] xfrm: fix IPv6 atomic fragment policy handling netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avbsF2Fmc2G4Nztg@gauss4 \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=idosch@nvidia.com \
--cc=jeremy.jean@oss.cyber.gouv.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®