From: Sean Christopherson <seanjc@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Pratik R. Sampat" <prsampat@amd.com>,
kvm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, tglx@kernel.org, mingo@redhat.com,
dave.hansen@linux.intel.com, pbonzini@redhat.com,
thomas.lendacky@amd.com, kim.phillips@amd.com, nikunj@amd.com,
michael.roth@amd.com, ashish.kalra@amd.com
Subject: Re: [Patch v4 3/4] x86/sev: Add guest support for Enhanced SMT Protection
Date: Fri, 13 Nov 2026 08:46:30 -0800 [thread overview]
Message-ID: <avc-5lkQhoR6US9o@google.com> (raw)
In-Reply-To: <20261112184929.GGavYKObGQNQ0wbDpD@fat_crate.local>
On Thu, Nov 12, 2026, Borislav Petkov wrote:
> On Mon, Nov 09, 2026 at 08:35:13PM +0000, Pratik R. Sampat wrote:
> > @@ -849,6 +850,18 @@ static int wakeup_cpu_via_vmgexit(u32 apic_id, unsigned long start_ip, unsigned
> > vmsa->vmpl = snp_vmpl;
> > vmsa->sev_features = sev_status >> 2;
> >
> > + if (sev_status & MSR_AMD64_SEV_SNP_ENABLED &&
> > + (sev_status & MSR_AMD64_SNP_ESMT_PROT)) {
> > + vmsa->vcpu_id = apic_id;
> > + /*
> > + * The mask fully set puts every vCPU in one group, so any two
> > + * of them may be co-resident. A legal ESMTP sibling must
> > + * also match on ASID, so the sibling of a vCPU in guest mode is
> > + * always either another vCPU of this same guest or idle.
> > + */
>
> This comment doesn't belong here.
>
> In any case, this set touches multiple trees so I'm open to suggestions from
> KVM folks how we should do the patch merging tetris eventually.
Post and merge the guest patches separately, and put any architectural collateral
need for the guest code in those patches. This is not high on my todo list, i.e.
the KVM patches can come later.
next prev parent reply other threads:[~2026-11-13 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 20:35 [Patch v4 0/4] Introduce Enhanced SMT Protection for SEV-SNP Pratik R. Sampat
2026-11-09 20:35 ` [Patch v4 1/4] KVM: SVM: Re-queue events that were never injected Pratik R. Sampat
2026-11-09 20:35 ` [Patch v4 2/4] KVM: SVM: Add host support for Enhanced SMT Protection Pratik R. Sampat
2026-11-09 20:35 ` [Patch v4 3/4] x86/sev: Add guest " Pratik R. Sampat
2026-11-12 18:49 ` Borislav Petkov
2026-11-13 16:46 ` Sean Christopherson [this message]
2026-11-09 20:35 ` [Patch v4 4/4] x86/hyperv: " Pratik R. Sampat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avc-5lkQhoR6US9o@google.com \
--to=seanjc@google.com \
--cc=ashish.kalra@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=prsampat@amd.com \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®