From: Herbert Xu <herbert@gondor.apana.org.au>
To: Thorsten Blum <blum@kernel.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Olivia Mackall <olivia@selenic.com>,
virtualization@lists.linux.dev, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hwrng: virtio - simplify probe_common()
Date: Fri, 13 Nov 2026 21:06:37 +0800 [thread overview]
Message-ID: <avcLXfYmR6raRZlN@gondor.apana.org.au> (raw)
In-Reply-To: <20261103165026.454333-3-blum@kernel.org>
On Tue, Nov 03, 2026 at 05:50:27PM +0100, Thorsten Blum wrote:
> Drop the redundant NULL initialization since vi is immediately
> reassigned. Drop the redundant index variable and use vi->index
> directly. Also call ida_free() directly and consolidate the error
> cleanup paths.
>
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> ---
> drivers/char/hw_random/virtio-rng.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-11-13 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 16:50 Thorsten Blum
2026-11-03 16:50 ` [PATCH 2/2] hwrng: virtio - simplify virtrng_restore() Thorsten Blum
2026-11-13 13:06 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avcLXfYmR6raRZlN@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=blum@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=olivia@selenic.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®