From: Philip Li <philip.li@intel.com>
To: Xiangwu Lai <laixiangwu@cmss.chinamobile.com>
Cc: kernel test robot <lkp@intel.com>, <gregkh@linuxfoundation.org>,
<jirislaby@kernel.org>, <hugo@hugovil.com>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<oe-kbuild-all@lists.linux.dev>, <llvm@lists.linux.dev>
Subject: Re: [PATCH v2] serial: sc16is7xx: Fix clock leak on invalid clock frequency
Date: Mon, 16 Nov 2026 13:01:25 +0800 [thread overview]
Message-ID: <avqOJTuXmpQnRpwK@rli9-mobl> (raw)
In-Reply-To: <20261116031043.503-1-laixiangwu@cmss.chinamobile.com>
On Mon, Nov 16, 2026 at 11:10:42AM +0800, Xiangwu Lai wrote:
> Hi,
>
> thanks for the reports. The build error is an artifact of the test
> setup, not a problem in the patch itself.
Thanks for detail info, and sorry about the false reports, i will further
check to fix the bot issue.
Thanks
>
> Both reports build v2 on top of the linux-review branch created
> for the original 2026-10-30 posting, i.e. on top of the superseded
> v1. v1 redirected the invalid-frequency -EINVAL path to a "goto
> out_clk", making use of the error label that exists in mainline.
> v2 is a full rework that replaces v1: it switches to
> devm_clk_get_optional_enabled(), so the -EINVAL path keeps its
> original plain return, exactly like mainline, and the mainline
> out_clk label is removed. Since the -EINVAL path is identical in
> mainline and in v2, v2's diff does not touch that line at all.
> Stacking v2 on top of the v1 baseline therefore leaves v1's
> "goto out_clk" in the invalid-frequency path while the label is
> removed, which produces exactly the reported "use of undeclared
> label 'out_clk'" at sc16is7xx.c:1622.
>
> I verified this locally: v2 applies cleanly on top of current
> mainline and the result contains no reference to out_clk at all,
> while applying v2 on top of v1 reproduces the dangling goto
> reported here.
>
> So there is nothing to fix in v2. It was posted as a standalone
> replacement for v1 (as a new top-level thread), and the build
> error only shows up when it is stacked on top of the v1 baseline.
>
> Best regards,
> Xiangwu Lai
>
>
>
next prev parent reply other threads:[~2026-11-16 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 10:38 Xiangwu Lai
2026-11-13 20:03 ` Hugo Villeneuve
2026-11-13 22:31 ` kernel test robot
2026-11-16 3:10 ` Xiangwu Lai
2026-11-16 5:01 ` Philip Li [this message]
2026-11-13 23:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avqOJTuXmpQnRpwK@rli9-mobl \
--to=philip.li@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=jirislaby@kernel.org \
--cc=laixiangwu@cmss.chinamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®