From: Jelly Jia <Jelly.Jia@cixtech.com>
To: Brian Masney <masneyb@kernel.org>
Cc: vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, robin.murphy@arm.com, sboyd@kernel.org,
bmasney+clk@redhat.com, jbrunet+clk@baylibre.com,
devicetree@vger.kernel.org, Frank.Li@kernel.org,
cix-kernel-upstream@cixtech.com, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
joakim.zhang@cixtech.com
Subject: Re: [PATCH v3 2/5] clk: cix: Handle Sky1 AUDSS DMA interrupt gates as an irqchip
Date: Mon, 16 Nov 2026 20:31:50 +0800 [thread overview]
Message-ID: <avr3tuaSUxAZObcz@ubuntu> (raw)
In-Reply-To: <179443508445.1143992.8301638068435530250.b4-review@b4>
Hi Brian,
> The irqchip driver doesn't belong in the clk subsystem, and it needs to
> go in the irqchip subsystem. You can use the auxilary device like what's
> done for the reset driver today.
Thanks, I'll move the IRQ implementation into a new auxiliary driver under
drivers/irqchip/, following the existing reset driver pattern.
The clock driver will register the auxiliary device, and the IRQ driver
will use the parent's regmap and the same CRU DT node. No new DT node or
changes to reset-sky1-audss.c are needed. I'll preserve the CRU power and
IRQ quiescing protections when splitting the implementation.
I'll include this in the next revision.
Best regards,
Jelly
next prev parent reply other threads:[~2026-11-16 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 1:35 [PATCH v3 0/5] soc: cix: Add the Sky1 AUDSS DMA-350 interrupt path Jelly Jia
2026-11-06 1:35 ` [PATCH v3 1/5] dt-bindings: soc: cix: Describe the Sky1 AUDSS DMA IRQ controller Jelly Jia
2026-11-11 9:08 ` Krzysztof Kozlowski
2026-11-16 12:31 ` Jelly Jia
2026-11-06 1:35 ` [PATCH v3 2/5] clk: cix: Handle Sky1 AUDSS DMA interrupt gates as an irqchip Jelly Jia
2026-11-11 22:11 ` Brian Masney
2026-11-16 12:31 ` Jelly Jia [this message]
2026-11-06 1:35 ` [PATCH v3 3/5] dt-bindings: dma: arm,dma-350: Document dma-channel-mask Jelly Jia
2026-11-06 1:35 ` [PATCH v3 4/5] dmaengine: arm-dma350: Honour dma-channel-mask Jelly Jia
2026-11-13 20:57 ` Frank Li
2026-11-06 1:35 ` [PATCH v3 5/5] arm64: dts: cix: Add the Sky1 AUDSS DMA-350 integration Jelly Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avr3tuaSUxAZObcz@ubuntu \
--to=jelly.jia@cixtech.com \
--cc=Frank.Li@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=joakim.zhang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®