mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Avi Weiss <thnkslprpt@gmail.com>
Cc: Chris Down <chris@chrisdown.name>, Petr Mladek <pmladek@suse.com>,
	John Ogness <john.ogness@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	printk@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Fix skipped entries after index iterator restart
Date: Mon, 16 Nov 2026 11:15:03 +0200	[thread overview]
Message-ID: <avrJl4lYirh_7oQ-@ashevche-desk.local> (raw)
In-Reply-To: <20261116085609.476250-2-thnkslprpt@gmail.com>

On Mon, Nov 16, 2026 at 10:56:10AM +0200, Avi Weiss wrote:
> seq_read_iter() can advance the iterator before the next record
> fits in the read buffer. When iteration resumes, pi_start() calls
> pi_next() at the saved position and advances past the pending printk
> index entry. As a result, index reads can silently omit formats.
> 
> Return the entry corresponding to the saved position without
> advancing the iterator.

...

> -	return pi_next(s, NULL, pos);
> +	return pi_get_entry(s->file->f_inode->i_private, *pos - 1);

Side note (because it seems used more in the same form), we have file_inode()
helper and this should idiomatically look as

	return pi_get_entry(file_inode(s->file)->i_private, *pos - 1);

But I haven't checked if the file_inode() is recommended or deprecated API.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-11-16  9:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  8:56 Avi Weiss
2026-11-16  9:15 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrJl4lYirh_7oQ-@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=chris@chrisdown.name \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=printk@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=thnkslprpt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®