From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Xiangwu Lai <laixiangwu@cmss.chinamobile.com>
Cc: Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-pwm@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH] pwm: mxs: Disable clock on invalid period error path
Date: Mon, 16 Nov 2026 10:29:05 +0100 [thread overview]
Message-ID: <avrMdLAPp2oOtdQA@monoceros> (raw)
In-Reply-To: <20261116031043.508-1-laixiangwu@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
[Cc: += Lee]
Hello,
On Mon, Nov 16, 2026 at 11:10:43AM +0800, Xiangwu Lai wrote:
> I've noticed that Lee Jones' series "pwm: Fix various bugs
> reported by Sashiko" also fixes the clock leak addressed by my
> patch below, with a broader scope:
>
> [PATCH 2/8] pwm: mxs: Return early when disabling and fix error-path clock leak
> https://lore.kernel.org/all/20261105143847.2559586-3-lee@kernel.org/
>
> Besides balancing clk_prepare_enable() on the same -EINVAL error
> path, that patch also handles the !state->enabled case upfront,
> avoiding a division by zero when state->period is zero, and it
> already carries a Reviewed-by from Frank Li.
>
> My patch for reference:
>
> pwm: mxs: Disable clock on invalid period error path
> https://lore.kernel.org/all/20261102105005.1007-1-laixiangwu@cmss.chinamobile.com/
>
> Please feel free to drop my patch in favour of Lee's more complete
> fix; there is no need to keep both.
Thanks for this follow-up, very appreciated. I marked your patch as
Superseded in patchwork in favour of Lee's patch.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-11-16 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 10:50 Xiangwu Lai
2026-11-16 3:10 ` Xiangwu Lai
2026-11-16 9:29 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avrMdLAPp2oOtdQA@monoceros \
--to=ukleinek@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=laixiangwu@cmss.chinamobile.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®