From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794827271; b=GPMn+kNRCEdoBQViYiXfaQYaRuvo6l8+4wvzBHU80eKTR4KWxwH+6w2EWXLP2GHUMnoM CSCD3tMxSWK0KZF6kLb3qv+UsuhuutJV4/dCct6FC8moe5TVzts8NrrXUXOVW40QwZQ2k Mlfi4loldy7+guthg3ANo9+Se//OXcbMMcj6SaCi0SvxTNSK3l84OGI/skNdOQ26Afj3B xSULaVveTmkgRvWwN+3dOj87IwqShSLDRFFksxlzE0cavA02htin09GtReD/co50CqPdj agZJGRAsAZem2JFkQehPbnjjpNkvrQ9RWmW1adLbmgXp1HCisfQ2aH3f1hw2S2HviTw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794827271; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=8X/VWMuk4kYzcSXRZvBmCXdDBR924lepSLdcXRzaC7s=; b=4WqWk8pUfqG1mMNFCQEK4pBZ8otby7e7pOidEQtXSwkI5lgrrIp0opDq+s8U1o04QSe8 MJTiWtC2lu3B1vsszsGNnFg+eZgsFY7D1KC4ANUYECzpV7oDm62YFw16KJoiksEfrh7ye gvYXCdDQvQBGBGDjkr+RXPRi35o2JiYCGJaxKREamG6jTq5lSMhvEWI8zlxSrR0YUubII PV6bH41B9nPktFnkPHl07zABaqkMt8s0cBonJ01lwokZrR7GT+csvGvoLDDRLGFbFMsCT 7jA7mwndIcEdpJwvBkuYZGpbS/IDeNXiStvfI/9ZF8ArOlM5cAIc3qAXNDr/2v1/g2g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bobrowski.net; spf=pass smtp.mailfrom=bobrowski.net; dkim=pass header.d=bobrowski.net header.i=@bobrowski.net header.a=rsa-sha256 header.s=google header.b=n4htZ6k+; arc=none smtp.remote-ip=209.85.215.172 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8F5B606F349 for ; Mon, 16 Nov 2026 11:07:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C8F5B606F349 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bobrowski.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bobrowski.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bobrowski.net header.i=@bobrowski.net header.a=rsa-sha256 header.s=google header.b=n4htZ6k+ Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-cc751eddf25so2631756a12.3 for ; Mon, 16 Nov 2026 03:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bobrowski.net; s=google; t=1794827270; x=1795432070; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=8X/VWMuk4kYzcSXRZvBmCXdDBR924lepSLdcXRzaC7s=; b=n4htZ6k+rXJjqOGHlTptUNPZZfhDILvPIkp8XPYQG93vq3RAHuWPgJJn/uh9dTFAKR yKgw265OmWLMx8yzQX/vtUAAujLx3554sGpsRLmjgUzCihnDAX3geHh8iorI9AeTqM4Z zFJuOb9l8M5tky5GKGORbBi1yV2CcFo7simUIX+ipyYuO3Y6O9W6Dc8/S6kmtlI3Dz9f w2Lz1spo1xcT5876mDB5GZoKoHqtoQ2SdEoba1+dKpLz0VCZgg1Rxm9MKAZXEJ0rp8Pp DVZ2DMvSihzUSjBu1hY9mAeQANNGw9Z/Wv5N8+YzIwZgBXkRrnwntzLVts7x8BNVSkj5 xZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794827270; x=1795432070; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8X/VWMuk4kYzcSXRZvBmCXdDBR924lepSLdcXRzaC7s=; b=uVv7kUY500xVlsq9ifn6yLJbrr0g31LqFTTUObRn9QUUFQ/5jRLNsArcN0NdbOZmqf J/rUTT2/CqBXtK5P2Uv5I6e8j3bW6UaFePB+Oin16NFtjmPADDNCqfr4u4BT/d87aW28 uyzM13748yU5ZjT9QCL1W78q/v5pyGYstb9HtxFTAaMcJpPEMvYeGIfqCPqVf0DUj1Bk PwQ1wU5Inb8GgBMGGrEoJ7GH8rdwRPPmtTM5kKoOy1h/fcCVEPsXTd3RuJ3bj8zA3Mt7 po/YdFzhg7mJG7WyQBIh7PqvGvDcijfVmZ/uqUcKKk0CCR7+SN0Wmw/6yK/yqdoTWZlW E+Fw== X-Forwarded-Encrypted: i=1; AL+hErFAZelsfE3xklc104Bb6+F3n/KxBVto9wkXRzptIxXAlInxdXpbpWrx/JmyHzW+JUAt4yJg9cKbvGiw9x8=@vger.kernel.org X-Gm-Message-State: APuU4Z/pLt6MfSkWxDHM5fhK19ur1VSP9QmIxciam8OuVCl99n/CvhCo a+53qzBxvlVnKPNcjn+b/pd7RDEZ7S4YbKF+KFEtkwwFD1HDJ1MpqSqvOE2Y3NmeYVGk X-Gm-Gg: AZFdTZdSH5FVDu2vo865WR63+K7OUlbgj7l6oaM+q/VuVbKm1nadqOXe+Stsa3dEu3B FcPzGZgISW/j0+zcYJbd07m7vgA5pB9WBqNXqJ9g5HlK5AqQ7mdlPFFqDK3LWkxtW1vHwLF3RHg a8C5Aa9JptxPtkN1mh3lHenDg+6NLuYB9pRY9OiuEUJOih0LAScEppK9/Rmt7f5PiRwYgw0pzV9 MK4TpbBDgqzE8LjmBe+mr8nxhFRo6ziXylgmVh30qBLyrvzVoHQeBIVBPOdeaw7OXBUXuiaw7vN iiNVVjb8LltsTgK/XBEmiYR+VMxFB0vwQdhFgQC0AAUdhpuUMiBM4J+ZiTfDCJluMbExy3UYDrs QkVby+OGAgYjB3Lf4irWTjOvZd+HpgrbWelziU0KAnB8QB5sejfQwNY5R3/kC63Zrvhg752b9Un fzdK8ylk2B/T9QcpL1YLMzbAL9uENIOaZt3cUJyq6c20WSPBHatCO7ZUjEChX9jQRTt2/YHoDdC G+Xq+2LP35PbhvODHgJh/Jetp0iqpTZWo/J2StqLmGndZBp/vg2Un2rkC8w5cnmH4tqbbXGumS4 sozAu1VDz1KdlNFJHNNCKoLX7AwKTg6xNMJVswV2+zpMSShgWyYWk2fuaSfkQ8/NeGStEqWGTEO pmRFIgwQ= X-Received: by 2002:a17:903:3843:b0:2d9:4358:73ab with SMTP id d9443c01a7336-2ee0daa351bmr102383795ad.19.1794827269844; Mon, 16 Nov 2026 03:07:49 -0800 (PST) Received: from lima-development (163-53-146-70.ip4.superloop.au. [163.53.146.70]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ee0f8d9966sm36823895ad.61.2026.11.16.03.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 03:07:49 -0800 (PST) Date: Mon, 16 Nov 2026 22:07:40 +1100 From: Matt Bobrowski To: Sergei Nizovtsev Cc: bpf@vger.kernel.org, linux-security-module@vger.kernel.org, stable@vger.kernel.org, KP Singh , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Serge Hallyn , Amir Goldstein , Paul Moore , Christian Brauner , linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf] bpf, lsm: Mark backing_file_alloc/free LSM hooks as untrusted Message-ID: References: <20261111203614.1221188-1-snizovtsev@cloudlinux.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261111203614.1221188-1-snizovtsev@cloudlinux.com> On Wed, Nov 11, 2026 at 09:35:52PM +0100, Sergei Nizovtsev wrote: > The backing_file_alloc and backing_file_free LSM hooks get the backing > file as "struct file *backing_file", but its f_path is not populated > while they run: > > - security_backing_file_alloc() is called from init_backing_file() in > alloc_empty_backing_file(), before vfs_open() sets f_path, so > backing_file->f_path.dentry is NULL; > - security_backing_file_free() can run for a backing file whose open > failed and whose f_path was already cleared. > > Neither hook is listed in untrusted_lsm_hooks, so bpf_lsm_is_trusted() > lets BPF LSM programs use the argument as a trusted pointer. A program > attached to lsm/backing_file_alloc can pass &backing_file->f_path to the > trusted-args kfunc bpf_path_d_path(), and d_path() dereferences the NULL > dentry on the first open of a file on overlayfs: > > extern int bpf_path_d_path(const struct path *path, char *buf, > size_t sz) __ksym; > char buf[256]; > > SEC("lsm/backing_file_alloc") > int BPF_PROG(poc, struct file *backing_file, > const struct file *user_file) > { > bpf_path_d_path(&backing_file->f_path, buf, sizeof(buf)); > return 0; > } > > # bpftool prog load poc.bpf.o /sys/fs/bpf/poc autoattach > # cat > > Oops: general protection fault, probably for non-canonical address 0xdffffc000000000c: 0000 [#1] SMP KASAN NOPTI > KASAN: null-ptr-deref in range [0x0000000000000060-0x0000000000000067] > RIP: 0010:d_path+0xb4/0x810 > Call Trace: > bpf_path_d_path+0x26/0x70 > bpf_prog_f8f2e241d4ff7217_poc+0x33/0x37 > bpf_trampoline_6442521065+0x61/0xf9 > security_backing_file_alloc+0x78/0xe0 > alloc_empty_backing_file+0xf0/0x170 > backing_file_open+0xfd/0x290 > ovl_open_realfile+0x1ed/0x270 > ovl_open+0x1a9/0x2f0 > do_dentry_open+0x404/0x1280 > vfs_open_consume+0xba/0x4b0 > path_openat+0xc4f/0x1f60 > > Add both hooks to untrusted_lsm_hooks, next to file_alloc_security and > file_free_security, which are listed there for the same reason. The > program above is then rejected at load time with "R1 must be referenced > or trusted". I literally had a patch queued up and was just about to send it out for review. Thank you for this. > Fixes: 6af36aeb147a ("lsm: add backing_file LSM hooks") > Cc: stable@vger.kernel.org > Assisted-by: Claude:claude-fable-5-2 > Signed-off-by: Sergei Nizovtsev > --- > Tested on bpf.git master (475a0cfd02f1) under virtme-ng with KASAN: the > reproducer oopses without the patch and fails to load with it. Only the > backing_file_alloc case was reproduced; backing_file_free is from code > reading. > > kernel/bpf/bpf_lsm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c > index f58dce888ff4a..f39a3766f2245 100644 > --- a/kernel/bpf/bpf_lsm.c > +++ b/kernel/bpf/bpf_lsm.c > @@ -411,6 +411,8 @@ BTF_ID(func, bpf_lsm_bpf_map_free) > BTF_ID(func, bpf_lsm_bpf_prog_free) > BTF_ID(func, bpf_lsm_file_alloc_security) > BTF_ID(func, bpf_lsm_file_free_security) > +BTF_ID(func, bpf_lsm_backing_file_alloc) > +BTF_ID(func, bpf_lsm_backing_file_free) > #ifdef CONFIG_SECURITY_NETWORK > BTF_ID(func, bpf_lsm_sk_alloc_security) > BTF_ID(func, bpf_lsm_sk_free_security) > -- > 2.56.0 >