mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: vjardin@free.fr
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
	Jacky Bai <ping.bai@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP S32 Linux Team <s32@nxp.com>,
	Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH v6 1/5] dt-bindings: pinctrl: add the NXP LX2160A RCW pad mux
Date: Mon, 16 Nov 2026 11:02:37 -0600	[thread overview]
Message-ID: <avs3Ldd95mmdOSaG@SMW015318> (raw)
In-Reply-To: <20261115-for-upstream-lx2160a-rcw-pinmux-v1-v6-1-fbdce4565a5c@free.fr>

On Sun, Nov 15, 2026 at 02:27:31PM +0100, Vincent Jardin via B4 Relay wrote:
> From: Vincent Jardin <vjardin@free.fr>
>
> The LX2160A muxes its IIC, XSPI, SDHC, UART, IRQ, EVT, EC and USB pads
> from fields of the RCW: read-only in RCWSR12..14 and RCWSR27 of DCFG,
> changed at runtime through the override registers of its DCSR view.
>
> Describe the pad mux as a child of DCFG at its RCWSR12 to RCWSR14 and
> RCWSR27 windows: the override registers are at the same offsets of the
> DCSR view of the parent. One group per RCW field, one function per
> encoding.
>
> Each function lists the groups that take it, so a pair the driver
> would refuse, such as can on iic1, is refused by the schema.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  .../bindings/pinctrl/fsl,lx2160a-rcw-pinmux.yaml   | 309 +++++++++++++++++++++
>  1 file changed, 309 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,lx2160a-rcw-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,lx2160a-rcw-pinmux.yaml
> new file mode 100644
> index 000000000000..f835ebe332a9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,lx2160a-rcw-pinmux.yaml
> @@ -0,0 +1,309 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/fsl,lx2160a-rcw-pinmux.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LX2160A RCW pad muxes
> +
> +maintainers:
> +  - Vincent Jardin <vjardin@free.fr>
> +
> +description:
> +  The LX2160A muxes its IIC, XSPI, SDHC, UART, IRQ, EVT, EC and USB pads based
> +  on its RCW. The related fields are from the read-only RCWSR12 to RCWSR14 and
> +  RCWSR27 registers of DCFG, and can be changed at runtime by writing the RCW
> +  override registers in the DCSR view of DCFG. The node is a child of the DCFG
> +  node, which owns both views. Its reg are the RCWSR12 to RCWSR14 and the
> +  RCWSR27 windows of the CCSR view, and the override registers are at the same
> +  offsets of the DCSR view.
> +
> +properties:
> +  compatible:
> +    const: fsl,lx2160a-rcw-pinmux
> +
> +  reg:
> +    items:
> +      - description: RCWSR12 to RCWSR14
> +      - description: RCWSR27
> +
> +patternProperties:
> +  '-pins$':
> +    type: object
> +    $ref: pinmux-node.yaml#
> +    additionalProperties: false
> +
> +    properties:
> +      function:
> +        enum: [ asleep, can, evt, flexspi, flextimer, gpio, gtx-clk, i2c,
> +                irq, reset-req, rgmii, sdhc, sdhc-clk, sdhc-data, sdhc-data4,
> +                sdhc-spi, spi, tsec-1588, uart, uart3, uart4, usb ]
> +
> +      groups:
> +        items:
> +          enum: [ iic1, iic2, iic3, iic4, iic5, iic6, xspi1-data74,
> +                  xspi1-data30, xspi1-base, sdhc1-base, sdhc1-dir,
> +                  sdhc2-data74, sdhc2-base, uart1-soutsin, uart1-rtscts,
> +                  uart2-soutsin, uart2-rtscts, irq11-8, irq7-4, irq3-0,
> +                  evt4-3, evt2-0, clk-out, asleep, reset-req, ec1, ec2,
> +                  usb-ext, gtx-clk, sdhc1-ds ]
> +
> +    required:
> +      - function
> +      - groups
> +
> +    allOf:
> +      - if:
> +          properties:
> +            function:
> +              const: asleep
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ asleep ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: can
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic3, iic4 ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: evt
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic3, iic4, evt4-3, evt2-0, asleep ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: flexspi
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ xspi1-data74, xspi1-data30, xspi1-base,
> +                        sdhc2-data74, sdhc2-base ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: flextimer
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic2, irq7-4, irq3-0, evt4-3, evt2-0, clk-out ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: gpio
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic2, iic3, iic4, iic5, iic6, xspi1-data74,
> +                        xspi1-data30, xspi1-base, sdhc1-base, sdhc1-dir,
> +                        sdhc2-data74, sdhc2-base, uart1-soutsin,
> +                        uart1-rtscts, uart2-soutsin, uart2-rtscts,
> +                        irq11-8, irq7-4, irq3-0, evt4-3, evt2-0, clk-out,
> +                        asleep, reset-req, iic1, ec1, ec2, usb-ext, gtx-clk,
> +                        sdhc1-ds ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: gtx-clk
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ gtx-clk ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: i2c
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic2, iic3, iic4, iic5, iic6, sdhc2-data74, iic1 ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: irq
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ irq11-8, irq7-4, irq3-0 ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: reset-req
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ reset-req ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: rgmii
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ ec1, ec2 ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: sdhc
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic2, sdhc1-base, sdhc1-dir, sdhc2-data74,
> +                        sdhc2-base, sdhc1-ds ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: sdhc-clk
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic5, iic6 ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: sdhc-data
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ sdhc1-dir ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: sdhc-data4
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ sdhc1-base ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: sdhc-spi
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ sdhc1-base ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: spi
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ iic5, sdhc1-base, sdhc1-dir, sdhc2-base, sdhc1-ds ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: tsec-1588
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ ec2 ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: uart
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ uart1-soutsin, uart1-rtscts, uart2-soutsin,
> +                        uart2-rtscts ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: uart3
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ uart1-rtscts ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: uart4
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ uart2-rtscts ]
> +
> +      - if:
> +          properties:
> +            function:
> +              const: usb
> +        then:
> +          properties:
> +            groups:
> +              items:
> +                enum: [ usb-ext ]
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - $ref: pinctrl.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    pinctrl@12c {
> +        compatible = "fsl,lx2160a-rcw-pinmux";
> +        reg = <0x12c 0xc>, <0x168 0x4>;
> +
> +        iic3-i2c-pins {
> +            function = "i2c";
> +            groups = "iic3";
> +        };
> +
> +        iic3-gpio-pins {
> +            function = "gpio";
> +            groups = "iic3";
> +        };
> +    };
>
> --
> 2.43.0
>
>
>

  reply	other threads:[~2026-11-16 17:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 13:27 [PATCH v6 0/5] lx2160a: change the pad muxes through the RCW override Vincent Jardin via B4 Relay
2026-11-15 13:27 ` [PATCH v6 1/5] dt-bindings: pinctrl: add the NXP LX2160A RCW pad mux Vincent Jardin via B4 Relay
2026-11-16 17:02   ` Frank Li [this message]
2026-11-15 13:27 ` [PATCH v6 2/5] dt-bindings: soc: fsl: layerscape-dcfg: add the LX2160A pad-mux child Vincent Jardin via B4 Relay
2026-11-16 17:04   ` Frank Li
2026-11-15 13:27 ` [PATCH v6 3/5] soc: fsl: guts: add the RCW override of the pad muxes Vincent Jardin via B4 Relay
2026-11-16 17:08   ` Frank Li
2026-11-16 17:29     ` Vincent Jardin
2026-11-15 13:27 ` [PATCH v6 4/5] pinctrl: freescale: add the Layerscape RCW pad-mux driver Vincent Jardin via B4 Relay
2026-11-16 17:12   ` Frank Li
2026-11-16 17:36   ` Vladimir Oltean
2026-11-16 18:51     ` Vincent Jardin
2026-11-15 13:27 ` [PATCH v6 5/5] arm64: dts: lx2160a: describe the pad muxes as the DCFG RCW override Vincent Jardin via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avs3Ldd95mmdOSaG@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=chleroy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=ioana.ciornei@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ping.bai@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s32@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=vjardin@free.fr \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®