mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Aviv Bakal <avivb@amazon.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Zeev Zilberman <zeev@amazon.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] PCI/PM: Keep hotplug ports that can't wake from D3hot out of D3
Date: Mon, 16 Nov 2026 18:03:25 +0100	[thread overview]
Message-ID: <avs3XRxXT7BtbZse@wunner.de> (raw)
In-Reply-To: <20261116165627.2775780-1-avivb@amazon.com>

On Mon, Nov 16, 2026 at 06:55:22PM +0200, Aviv Bakal wrote:
> On Sun, Nov 15, 2026 at 07:22:33PM +0100, Lukas Wunner wrote:
> > Intel Catlow Lake suffers from a similar issue:
> >
> > https://lore.kernel.org/all/20261103193136.2410148-1-sathyanarayanan.kuppuswamy@linux.intel.com/
> >
> > Please try to follow the approach taken there.
> 
> Thanks Lukas. In the Catlow Lake case the Root Ports still signal the
> hot-add with a PME interrupt, and only PME Status is unreliable. Our
> ports are switch downstream ports that advertise PME from D3hot but
> never send a PM_PME message, so the Root Port gets no interrupt and a
> pcie_pme_irq() hook would never run. Keeping these ports out of D3
> looks like the only option for the existing devices.

We cache the power states which support PME in struct pci_dev::pme_support.
Have you considered just modifying that in a DECLARE_PCI_FIXUP_FINAL()
callback?  See e.g. pci_fixup_no_d0_pme(), pci_fixup_no_msi_no_pme(),
pci_fixup_amd_ehci_pme(), pci_fixup_amd_fch_xhci_pme().

> I sent a v2 that fixes a runtime PM imbalance in patch 1 when NO_D3 is
> set by a FINAL fixup.

Please wait one or two weeks before respinning to allow time for the
community to review your proposed changes and provide feedback.

Thanks,

Lukas

      reply	other threads:[~2026-11-16 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 17:18 Aviv Bakal
2026-11-15 17:18 ` [PATCH 1/3] PCI/PM: Honor PCI_DEV_FLAGS_NO_D3 in pci_bridge_d3_possible() Aviv Bakal
2026-11-15 17:18 ` [PATCH 2/3] PCI: Avoid runtime D3 on Amazon PCIe switch ports Aviv Bakal
2026-11-15 17:18 ` [PATCH 3/3] PCI/PM: Keep hotplug ports out of D3 if they can't signal PME from D3hot Aviv Bakal
2026-11-15 17:22 ` [PATCH 0/3] PCI/PM: Keep hotplug ports that can't wake from D3hot out of D3 Lukas Wunner
2026-11-16 16:55   ` Aviv Bakal
2026-11-16 17:03     ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avs3XRxXT7BtbZse@wunner.de \
    --to=lukas@wunner.de \
    --cc=avivb@amazon.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=zeev@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®