mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Leitner <richard.leitner@linux.dev>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
	 Mauro Carvalho Chehab <mchehab@kernel.org>,
	Daniele Alessandrelli <daniele.alessandrelli@gmail.com>,
	 "Paul J. Murphy" <paul.j.murphy@intel.com>,
	Martina Krasteva <martinax.krasteva@intel.com>,
	 Hans Verkuil <hverkuil+cisco@kernel.org>,
	Bryan O'Donoghue <bod@kernel.org>,
	 Jacopo Mondi <jacopo@jmondi.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	 Gyula Kelemen <gyula.kelemen@advasolutions.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH v3 0/8] media: i2c: ov9282: fix strobe timing and control handling
Date: Mon, 16 Nov 2026 14:48:45 +0100	[thread overview]
Message-ID: <avsJn4mRwTHJWjJk@bombadil> (raw)
In-Reply-To: <avr2lDQxiFnv2Gq8@kekkonen.localdomain>

Hi Sakari,

On Mon, Nov 16, 2026 at 02:27:00PM +0200, Sakari Ailus wrote:
> Hi Richard,
> 
> On Tue, Nov 10, 2026 at 02:10:09PM +0100, Richard Leitner wrote:
> > This series fixes a set of related issues in the OV9282 strobe timing
> > and control handling code.
> > 
> > The driver updated exposure- and flash duration-related control ranges
> > in several places, but some of those updates used an incorrect timebase
> > or were triggered too late, which could leave the controls clamped
> > against stale values.
> > 
> > The series:
> > - checks the return value of the exposure range update
> > - drops the redundant vblank field
> > - converts probe error messages to dev_err_probe()
> > - fixes the 8-bit pixel rate (192 MHz instead of 200 MHz) and the
> >   corresponding line time calculation
> > - treats the strobe frame span as a line count and converts the flash
> >   duration accordingly
> > - fixes the flash duration range (min/max/default) and refreshes it on
> >   HBLANK changes, independent of the sensor power state
> > - refreshes the exposure and flash duration ranges on mode changes
> > - reprograms the strobe span when HBLANK changes
> > 
> > This series was tested with an ov9282 sensor on a vision components camera
> > module attached to an i.MX8MP mainboard in a defined (dark) environment
> > with a custom made LED flash pcb.
> > 
> > Any feedback is warmly welcome.
> 
> Can you fix the issues 0-day bot found? I think the patches seem fine
> otherwise.

Sure. I will send a v4 in a few minutes. Thanks for the reminder!

regards;rl

> 
> -- 
> Regards,
> 
> Sakari Ailus

      reply	other threads:[~2026-11-16 13:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 13:10 Richard Leitner
2026-11-10 13:10 ` [PATCH v3 1/8] media: i2c: ov9282: handle error from exposure range update Richard Leitner
2026-11-10 13:10 ` [PATCH v3 2/8] media: i2c: ov9282: fix pixel rate and line time calculation Richard Leitner
2026-11-10 13:10 ` [PATCH v3 3/8] media: i2c: ov9282: fix flash duration to/from microseconds conversion Richard Leitner
2026-11-11  2:10   ` kernel test robot
2026-11-11 10:29   ` kernel test robot
2026-11-10 13:10 ` [PATCH v3 4/8] media: i2c: ov9282: fix flash duration range calculation Richard Leitner
2026-11-10 13:10 ` [PATCH v3 5/8] media: i2c: ov9282: add refresh of additional ranges on a mode change Richard Leitner
2026-11-10 13:10 ` [PATCH v3 6/8] media: i2c: ov9282: recalculate strobe span on HBLANK change Richard Leitner
2026-11-11  4:46   ` kernel test robot
2026-11-10 13:10 ` [PATCH v3 7/8] media: i2c: ov9282: drop redundant vblank field Richard Leitner
2026-11-10 13:10 ` [PATCH v3 8/8] media: i2c: ov9282: harmonize dev_err_probe usage Richard Leitner
2026-11-16 12:27 ` [PATCH v3 0/8] media: i2c: ov9282: fix strobe timing and control handling Sakari Ailus
2026-11-16 13:48   ` Richard Leitner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avsJn4mRwTHJWjJk@bombadil \
    --to=richard.leitner@linux.dev \
    --cc=bod@kernel.org \
    --cc=daniele.alessandrelli@gmail.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=gyula.kelemen@advasolutions.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jacopo@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martinax.krasteva@intel.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.j.murphy@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®