From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794839179; b=oRCBpWL5NLcETyeRaJufeN5u+Glwm0D/O7vaupziEcpjYeBuK9xGS5RRBGM69nx5PNIV k5y5ipJAA1iRZc1XB2X9tsbATSaJHL6XfXgvTrG4LjRGdgI0o0Z0jWjoh2iEGTiAhy50B fjlYL5C45lWxDzlWJtAgGXfvXZfM1em+zvO5jq+n/7QD2wSyWrgFlD/ER4DR7hMLnMOU1 l/juL7UG/4SZSjVcZpRTJinPXEW1cr2NBrbAGmuIvyXH2adLQO6oMtznTZOn28aZUEy05 yvVdKBpuy5nWqb3HVci+iG6z+3AbB/sFmJgEYDs+rM0YmItxw6tvExVOl3pa2sbW+sw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794839179; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=nCuKQ2B+U6EFNvvi/XwnoZbaxFRZS/VTpXWrU5IbtZY=; b=HHCaU23GGFfPJzb1pRDRTfSQaLlDiJUOXZLNvVz3Qjg3VaFfB47J5hUeIAn6xPHRQOd0 j4LwsbsVeqfAXUY40GOOLFCW/QzJ2gPjQchPfCYa8TgvuG8pc1wZoFGF235/VB2PyZht5 3JeOP1A5gNNgOkVBEc2A3ODAUwHtsfVg5C85Iy35tgTXg+FpHS/i4AfgtxmQnsN6VZHY0 gd696L9FNEYMezs1Yz5+6b050m2HOyOXvzfp4p+2szYpDLQ/mlkg2y6qu4AJxaPcDdtFs sP1iNg2fI0E43VwwEuK2meuj0Msw3LeLTFnDDyznEhGx/9/XwM6UVgCb7o9mAOxj4wA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IhrywX5z; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=kF2jTtyN; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C29F4606A886 for ; Mon, 16 Nov 2026 14:26:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C29F4606A886 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IhrywX5z; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=kF2jTtyN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794839177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nCuKQ2B+U6EFNvvi/XwnoZbaxFRZS/VTpXWrU5IbtZY=; b=IhrywX5zrNjRPhxapIkJ+LgWRujWeq3t+jiXFO0HBoIk+pnLkStgT2Q9/Osd5cRFmg9suB ZxJmLd7UtfphMtpWtxXboBmsucNozGYqaeoLUD6WfIxaY+t7cv20TquZ5P72WOX56EB0FN do6+VBiZ6/1Crtm2GkHMZg6Jts6Jpig= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-YsgbqyYbNgW_8HB9_b26Eg-1; Mon, 16 Nov 2026 09:26:16 -0500 X-MC-Unique: YsgbqyYbNgW_8HB9_b26Eg-1 X-Mimecast-MFC-AGG-ID: YsgbqyYbNgW_8HB9_b26Eg_1794839175 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a17741243eso18141825e9.0 for ; Mon, 16 Nov 2026 06:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1794839175; x=1795443975; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nCuKQ2B+U6EFNvvi/XwnoZbaxFRZS/VTpXWrU5IbtZY=; b=kF2jTtyNIOSCU2A+vnCWysiG5eNF3XvL53kiM0+I8sIKTQCPhpt/9w2zgAWTjO1sbo sxQc8akoz1aYsdG5jskfqEC6f2cL1JvveNa/ckaMXQw4AksirhTClWxGzPcm9Ccuanoy HNqYW7O5tKFhdaU1KV9cUbeBloD0AwD/TvD/AChhNZSKPJ3GG+XN9L3mHwb1n3XxNeOj 7fWFe8ENYQJSyy4FKEe77TIMz01kQSGPguFL1Ofu2k800bX0hzmcgBxwhhq+BmShrUMd owNFF3INuCUDtD1oEK1oAAjc9JHUkz4aZ3BERpAiggKHX8AINtY8LxhrsnkZhdGxlI33 0HAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794839175; x=1795443975; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nCuKQ2B+U6EFNvvi/XwnoZbaxFRZS/VTpXWrU5IbtZY=; b=s7TvT+63urUro9DoWiqDsiNCT/9F/CgF4vcPi2GzcCAJgPmiTBAVM1K0RAY0GvqwXy Oln8v6LcswzLgpal6VVY839MnYt1kQU/Ip5dYiM8BAXf7vmdBvB1st9ES9H3Fnli+QjJ VyiGqdKromlwBdrS14QzV/mXMlZMg+PS1uUmX+Yv7IqOTMvB8zDGdyDAR11dN/tIKW8k wkT+xZzVQJegt2HC3K7S0F41UWFr9HxNuP1y9W5+fLcPIR8UB3GccL7lM7dRswmp4vMs FCM3ml5A9fhz8EBThmDLijViV8mikjblWUakpcxDYETSV4eYF2b+IpR3tngWfxaj7Dxe YTyg== X-Forwarded-Encrypted: i=1; AL+hErGfUUzrxyV/cdaiGCSJqXPbeQPNT6zDkrx49IYNCznQWCA6wOyPWLU9j3SUQKpXZzDZcAD41fblT8L+jI0=@vger.kernel.org X-Gm-Message-State: APuU4Z8peOqUA1+R9gP0lJz+doudtWZisenj8sWwnGqhOocLWhTfsgsp dSuuoGJqrSFnXHCEiHExHc6e37Tp7iMKD+p8JtX+7cnwGA3kYJFuS7qBCEBfPpE8EDzKxCrvHeY F6SqSCZolQShq3dobVye/c9pe6sHlOvF5NsNTV7B5U9qW0Lk4yxzN17gNLtIKbUWAgw== X-Gm-Gg: AYBFou1/ByTUdT2eWsdGl+pcaKcKiV9lzt0YVUF4JQ+lOeoXeauJGHPhx13/qZq4Oay cixdW3EKCDrmGo01DKd5rA/g3hO6RzfuWDDkwdJ2/wNxuy7FctEXWu87ECkCPNST1EIYaIYzrFz 0A2flYfB+0gEC3rxFm93rFOhUtZJDpPq94SA6NroV0E3j1y6t1ioYCI+1zArCC5M8FgNQ+llRtU mWGg9QbB4Qkjv649g9ZRNHO1sU42TL1veginb/zppyJU4ZGlOddlopXw2NkUK2izbPei5VE8y4k m/cyT3pakc9Y4yf/Wc3DMh9bWuyCClzBGXRYZW77KmiCPQwbE2neEZlnhTtDVltwnQBXIEOuE7D 8pcxjRi30VBhIsOI1CRqeITex5qdMZbtMCzHVz2hqReQyp5Huv/iPB0yFFO1qaTll2Kqe1QfzwB h4SWo= X-Received: by 2002:a05:600c:c4a3:b0:4a1:9663:7639 with SMTP id 5b1f17b1804b1-4bb55ab5526mr234942025e9.34.1794839174894; Mon, 16 Nov 2026 06:26:14 -0800 (PST) X-Received: by 2002:a05:600c:c4a3:b0:4a1:9663:7639 with SMTP id 5b1f17b1804b1-4bb55ab5526mr234941455e9.34.1794839174492; Mon, 16 Nov 2026 06:26:14 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.158.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb56689bc2sm176845115e9.2.2026.11.16.06.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 06:26:07 -0800 (PST) Date: Mon, 16 Nov 2026 15:25:57 +0100 From: Juri Lelli To: Yuri Andriaccio Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Abeni , Yuri Andriaccio Subject: Re: [RFC PATCH v7 00/29] Hierarchical Constant Bandwidth Server Message-ID: References: <20261109163616.195264-1-yurand2000@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261109163616.195264-1-yurand2000@gmail.com> Hello, On 09/11/26 17:35, Yuri Andriaccio wrote: ... > Version v7 introduces a lot of changes since v6. First off there have been a > lot of bug fixes from the comments by the reviewers and the automated AI tool > Sashiko, which surprisingly caught a lot of issues. Later, we've finally had > time to add features which were planned a long time ago. The following are the > most meaningful updates since v6 (the complete changelog can be found on the > github readme): > - Rebase to kernel version 7.4-rc1. > - Address (most of) bugs as reported in the v6 reviews. > - Introduce dl_freq_invariant flag for dl_servers. > + Force fair/ext servers to be frequency/capacity invariant, while allow > HCBS servers to scale their consumed runtime. > + This enables capacity-aware bandwidth reservation also for HCBS. > - Rework cgroup-v2 interface: > + Rename cpu.rt.internal to cpu.rt.effective.local > + Fix internal runtime rounding errors. > - Update cgroup balance callbacks to allow balancing operation of multiple > cgroups at the same time. > - Allow unprivileged FIFO/RR tasks inside cgroups. > - Allow HRTICK_DL for HCBS servers. > - Integrate `cpu` and `cpuset` controllers. > - Integrate HCBS with hotplug/hotunplug operations. > - Introduce dl_server overrides (previously known as multi-runtime/multi-CPU). ... > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > Testing v7: > > The patchset has been tested with a suite of tests tailored to stress all the > implemented functionalities. > The tests are available at https://github.com/Yurand2000/HCBS-Test-Suite . > Refer to the README of the repository for more details. > > Follow these steps to test HCBS v7: > - Get the HCBS patch up and running. Any kernel/disto should work effortlessly. > - Get, compile and _install_ the tests. > - Run the `go_rt.sh` script to set the frequency of the CPUs to a fixed value > and disable hyperthreading and power saving features. > - Run the `run_tests.sh full` script, to run the whole test suite. > > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - I think Sashiko already commented about it, but I had to apply the following to make the series compile with clang. BTW, since you already received comments from Tejun and Sashiko also raised lots of stuff to look at, shall I wait for a v8 before engaging as well, so that you don't get overwhelmed? :) Thanks for your work! Juri --- kernel/sched/rt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 8702d0e0c4e3c..c9c8752a61532 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -3113,11 +3113,13 @@ static int sched_rt_global_validate(void) DEFINE_MUTEX(sched_rt_handler_mutex); -void sched_rt_handler_mutex_lock() { +void sched_rt_handler_mutex_lock(void) +{ mutex_lock(&sched_rt_handler_mutex); } -void sched_rt_handler_mutex_unlock() { +void sched_rt_handler_mutex_unlock(void) +{ mutex_unlock(&sched_rt_handler_mutex); }