mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Tal Zussman <tz2294@columbia.edu>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Mike Rapoport" <rppt@kernel.org>, "Peter Xu" <peterx@redhat.com>,
	"James Houghton" <jthoughton@google.com>,
	"Andrea Arcangeli" <aarcange@redhat.com>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Balbir Singh" <balbirs@nvidia.com>,
	"Liam R. Howlett" <liam@infradead.org>,
	"Vlastimil Babka" <vbabka@kernel.org>,
	"Jann Horn" <jannh@google.com>,
	"Pedro Falcato" <pfalcato@suse.de>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Andrei Vagin" <avagin@gmail.com>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Muhammad Usama Anjum" <usama.anjum@arm.com>,
	"David Hildenbrand" <david@kernel.org>, "Zi Yan" <ziy@nvidia.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Joshua Hahn" <joshua.hahnjy@gmail.com>,
	"Byungchul Park" <byungchul@sk.com>,
	"Gregory Price" <gourry@gourry.net>,
	"Ying Huang" <ying.huang@linux.alibaba.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Nico Pache" <nico.pache@linux.dev>,
	"Ryan Roberts" <ryan.roberts@arm.com>,
	"Dev Jain" <dev.jain@arm.com>, "Barry Song" <baohua@kernel.org>,
	"Lance Yang" <lance.yang@linux.dev>,
	"Usama Arif" <usama.arif@linux.dev>,
	"Kiryl Shutsemau" <kas@kernel.org>,
	"Chris Down" <chris@chrisdown.name>,
	"Muchun Song" <muchun.song@linux.dev>,
	"Oscar Salvador" <osalvador@suse.de>,
	"Mikołaj Lenczewski" <miko.lenczewski@arm.com>,
	"Michal Hocko" <mhocko@suse.com>,
	"Mike Kravetz" <mike.kravetz@oracle.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 04/12] mm/migrate: keep the uffd bit when restoring a writable migration entry
Date: Mon, 16 Nov 2026 14:41:45 +0000	[thread overview]
Message-ID: <avsV68cP0rp5mWSf@gremlin> (raw)
In-Reply-To: <f28dc841-f664-4f97-9dd7-bffd2825115e@columbia.edu>

On Fri, Nov 13, 2026 at 04:59:39PM -0500, Tal Zussman wrote:
> On 11/12/26 1:44 PM, Lorenzo Stoakes (ARM) wrote:
> > On Wed, Nov 11, 2026 at 12:55:12PM -0500, Tal Zussman wrote:
> >> remove_migration_pte() makes the restored PTE writable for a writable
> >> migration entry, and only looks at the uffd bit of the entry otherwise.
> >> A writable migration entry that has the uffd bit set is therefore
> >> restored as a writable PTE without the uffd bit, and the page is no
> >> longer write-protected.
> >
> > The UFFD WP bit is such a terrible, invasive, broken piece
> > of... engineering :)
> >
> > Notice, again, the hallmark of an utterly broken abstraction - every user
> > just has to happen to know to handle each of your weird edge cases every
> > single time they happen to interact with anything that touches it.
> >
> > I do hope we never merge something as bad as this again.
> >
> >>
> >> An entry with the uffd bit set must be restored write-protected, whether
> >> the entry is writable or not. remove_migration_pmd() gets this right: it
> >
> > Sigh :)
> >
> >> makes the PMD writable and sets the uffd bit as two independent steps,
> >> and pmd_mkuffd() write-protects the result. To fix it, do the same at
> >> the PTE level, where pte_mkuffd() write-protects the PTE as well.
> >>
> >> The only known path that created such entries is PAGEMAP_SCAN. Now that
> >
> > Wait what? :)
> >
> > How does a read-only scan of entries create softleaf entries?
> >
> > I think this should be explained in the commit message :)
> >
>
> Will add a sentence... unfortunately not a read-only scan...

Thanks! Yeah I realised later the true horrors of what PAGEMAP_SCAN can do
with uffd flags (ugh).

>
> >> PAGEMAP_SCAN downgrades them like change_protection() does, we should no
> >> longer see them, so this change alone should not be visible to
> >> userspace. If another path ever creates a writable migration entry with
> >> the uffd bit set, the page now stays write-protected instead of losing
> >> the uffd bit.
> >>
> >> Fixes: 52526ca7fdb9 ("fs/proc/task_mmu: implement IOCTL to get and optionally clear info about PTEs")
> >
> > This seems like a super-weird fixes target.
> >
>
> So this piece of code was added in f45ec5ff16a7, but the issue derives
> from PAGEMAP_SCAN, which is the commit above. I think 52526ca7fdb9 is
> the right target, but can change it.
>
> > BTW I've noticed you've not been cc'ing stable, is that on purpose? No
> > autosel in mm so we do need to do that on stuff intended to get backported.
> > :)
> >
>
> I added stable for patches 1 and 2, but for this one and the previous patch
> the impact is PAGEMAP_SCAN reporting a page as written when it wasn't, which
> over-reports but doesn't lose anything, so I left it off. Maybe I'm being
> too conservative though.

No that's fine, if it's sensible not to then let's not.

Was just checking to make sure it was intentional ;)

>
> >> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> >
> > The change itself seems reasonable, as cursed as the reason for it is, so
> > with the fixes target confirmed + commit message updated:
> >
> > Acked-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> >
> >> ---
> >>  mm/migrate.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/mm/migrate.c b/mm/migrate.c
> >> index 28a8d7734735..d200f64b5f98 100644
> >> --- a/mm/migrate.c
> >> +++ b/mm/migrate.c
> >> @@ -399,7 +399,7 @@ static bool remove_migration_pte(struct folio *folio,
> >>
> >>  		if (softleaf_is_migration_write(entry))
> >>  			pte = pte_mkwrite(pte, vma);
> >> -		else if (pte_swp_uffd(old_pte))
> >> +		if (pte_swp_uffd(old_pte))
> >>  			pte = pte_mkuffd(pte);
> >>
> >>  		/* See do_swap_page(): restore PAGE_NONE for RWP */
> >>
> >> --
> >> 2.39.5
> >>
> >
> > --
> > Cheers, Lorenzo
> >
>

--
Cheers, Lorenzo

  reply	other threads:[~2026-11-16 14:41 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 17:55 [PATCH 00/12] userfaultfd: assorted fixes (part 1) Tal Zussman
2026-11-11 17:55 ` [PATCH 01/12] userfaultfd: use anonymous memory for UFFDIO_ZEROPAGE on private file mappings Tal Zussman
2026-11-12 18:05   ` Lorenzo Stoakes (ARM)
2026-11-11 17:55 ` [PATCH 02/12] userfaultfd: refuse UFFDIO_MOVE into a non-present huge destination PMD Tal Zussman
2026-11-12 18:07   ` Lorenzo Stoakes (ARM)
2026-11-13  4:25   ` Gregory Price (Meta)
2026-11-11 17:55 ` [PATCH 03/12] fs/proc/task_mmu: downgrade writable migration entries in PAGEMAP_SCAN write-protect Tal Zussman
2026-11-12 18:34   ` Lorenzo Stoakes (ARM)
2026-11-13  4:55   ` Gregory Price (Meta)
2026-11-11 17:55 ` [PATCH 04/12] mm/migrate: keep the uffd bit when restoring a writable migration entry Tal Zussman
2026-11-12 18:44   ` Lorenzo Stoakes (ARM)
2026-11-13 21:59     ` Tal Zussman
2026-11-16 14:41       ` Lorenzo Stoakes (ARM) [this message]
2026-11-13  4:59   ` Gregory Price (Meta)
2026-11-15 23:57   ` Alistair Popple
2026-11-11 17:55 ` [PATCH 05/12] fs/proc/task_mmu: write-protect device-private THPs in PAGEMAP_SCAN Tal Zussman
2026-11-12 19:34   ` Lorenzo Stoakes (ARM)
2026-11-13  5:08     ` Gregory Price (Meta)
2026-11-16 14:46       ` Lorenzo Stoakes (ARM)
2026-11-13 22:16     ` Tal Zussman
2026-11-16 14:50       ` Lorenzo Stoakes (ARM)
2026-11-13  5:10   ` Gregory Price (Meta)
2026-11-11 17:55 ` [PATCH 06/12] mm/huge_memory: build the moved huge zero PMD from the destination VMA Tal Zussman
2026-11-11 19:12   ` Kiryl Shutsemau
2026-11-13  5:19   ` Gregory Price (Meta)
2026-11-11 17:55 ` [PATCH 07/12] mm/mremap: resolve uffd state when the context is dropped, not during the move Tal Zussman
2026-11-11 19:20   ` Kiryl Shutsemau
2026-11-11 22:39     ` Tal Zussman
2026-11-12 11:44   ` Lorenzo Stoakes (ARM)
2026-11-12 16:00     ` Tal Zussman
2026-11-13  5:46   ` Gregory Price (Meta)
2026-11-11 17:55 ` [PATCH 08/12] mm/migrate_device: do not migrate a uffd-protected zero page Tal Zussman
2026-11-13  6:04   ` Gregory Price (Meta)
2026-11-13 22:26     ` Tal Zussman
2026-11-16  0:11       ` Alistair Popple
2026-11-11 17:55 ` [PATCH 09/12] mm/madvise: let a guard marker carry the uffd-wp bit Tal Zussman
2026-11-12 11:21   ` Lorenzo Stoakes (ARM)
2026-11-12 16:06     ` Tal Zussman
2026-11-11 17:55 ` [PATCH 10/12] mm: set the uffd-wp bit on a guard marker when write-protecting Tal Zussman
2026-11-12 11:43   ` Lorenzo Stoakes (ARM)
2026-11-11 17:55 ` [PATCH 11/12] mm/madvise: send UFFD_EVENT_REMOVE when installing guard regions Tal Zussman
2026-11-11 19:25   ` Kiryl Shutsemau
2026-11-11 23:21     ` Tal Zussman
2026-11-12  9:40       ` Jose A. Perez de Azpillaga
2026-11-12 11:57         ` Kiryl Shutsemau
2026-11-12 11:03   ` Lorenzo Stoakes (ARM)
2026-11-12 11:06     ` Lorenzo Stoakes (ARM)
2026-11-12 15:56     ` Tal Zussman
2026-11-11 17:55 ` [PATCH 12/12] mm/userfaultfd: check hugetlb end alignment in UFFDIO_UNREGISTER pre-scan Tal Zussman
2026-11-12 19:52   ` Lorenzo Stoakes (ARM)
2026-11-13 22:34     ` Tal Zussman
2026-11-16 14:42       ` Lorenzo Stoakes (ARM)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avsV68cP0rp5mWSf@gremlin \
    --to=ljs@kernel.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=arnd@arndb.de \
    --cc=avagin@gmail.com \
    --cc=balbirs@nvidia.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=byungchul@sk.com \
    --cc=chris@chrisdown.name \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=gourry@gourry.net \
    --cc=jannh@google.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=jthoughton@google.com \
    --cc=kas@kernel.org \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew.brost@intel.com \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=miko.lenczewski@arm.com \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=osalvador@suse.de \
    --cc=peterx@redhat.com \
    --cc=pfalcato@suse.de \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=surenb@google.com \
    --cc=tz2294@columbia.edu \
    --cc=usama.anjum@arm.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®