From: Johan Hovold <johan@kernel.org>
To: "Rafael J. Wysocki (Intel)" <rafael@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
driver-core@lists.linux.dev, linux-acpi@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [PATCH v2 8/8] device property: fix fwnode_get_next_child_node() comments
Date: Mon, 16 Nov 2026 15:54:47 +0100 [thread overview]
Message-ID: <avsZN96lgaW5IHdh@hovoldconsulting.com> (raw)
In-Reply-To: <CAJZ5v0g+X0etuZSoTrFr2OXgF9o0q+LLLTcQSfvo0A3dib9M4Q@mail.gmail.com>
On Fri, Nov 13, 2026 at 06:49:54PM +0100, Rafael J. Wysocki wrote:
> On Tue, Nov 10, 2026 at 9:52 AM Johan Hovold <johan@kernel.org> wrote:
> >
> > The parent pointer in fwnode_get_next_child_node() may not point to a
> > primary firmware node so update the comments to reflect that.
> > @@ -822,12 +822,12 @@ fwnode_get_next_child_node(const struct fwnode_handle *fwnode,
> > if (IS_ERR_OR_NULL(parent))
> > return NULL;
> >
> > - /* Try to find a child in primary fwnode */
> > + /* Try to find a child in parent */
>
> I'm not sure if this comment is still useful after the change, so
> maybe drop it altogether?
Sounds good.
> > next = fwnode_call_ptr_op(parent, get_next_child_node, child);
> > if (next)
> > return next;
> >
> > - /* When no more children in primary, continue with secondary */
> > + /* When no more children in parent, continue with any secondary */
>
> What about
>
> /* Direct children exhausted, go to secondary */
That works, but I think I prefer not rewriting the comment completely,
and having "any" in there to indicate that we may already be scanning a
secondary node (in which case parent->secondary is -ENODEV).
So something like:
/* When no more children, continue with any secondary node */
>
> > return fwnode_get_next_child_node(parent->secondary, NULL);
> > }
> > EXPORT_SYMBOL_GPL(fwnode_get_next_child_node);
> > --
Johan
next prev parent reply other threads:[~2026-11-16 14:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 8:51 [PATCH v2 0/8] driver core: platform: fix swnode use-after-free on device release Johan Hovold
2026-11-10 8:51 ` [PATCH v2 1/8] " Johan Hovold
2026-11-13 17:23 ` Rafael J. Wysocki (Intel)
2026-11-10 8:51 ` [PATCH v2 2/8] i2c: core: fix swnode use-after-free on client deregistration Johan Hovold
2026-11-10 10:58 ` Andy Shevchenko
2026-11-10 11:15 ` Johan Hovold
2026-11-13 22:04 ` Wolfram Sang
2026-11-10 8:51 ` [PATCH v2 3/8] swnode: fix device_add_of_node() kernel doc Johan Hovold
2026-11-10 10:42 ` Johan Hovold
2026-11-10 11:00 ` Andy Shevchenko
2026-11-16 13:55 ` Johan Hovold
2026-11-10 8:51 ` [PATCH v2 4/8] swnode: ignore primary nodes in device_remove_software_node() Johan Hovold
2026-11-10 11:05 ` Andy Shevchenko
2026-11-13 17:29 ` Rafael J. Wysocki (Intel)
2026-11-16 14:05 ` Johan Hovold
2026-11-13 22:05 ` Wolfram Sang
2026-11-10 8:51 ` [PATCH v2 5/8] driver core: platform: warn on bad fwnode assignment Johan Hovold
2026-11-10 10:47 ` Johan Hovold
2026-11-10 8:51 ` [PATCH v2 6/8] driver core: platform: tests: fix swnode reuse test description Johan Hovold
2026-11-13 17:32 ` Rafael J. Wysocki (Intel)
2026-11-10 8:51 ` [PATCH v2 7/8] swnode: fix software_node_notify() primary node comment Johan Hovold
2026-11-10 8:51 ` [PATCH v2 8/8] device property: fix fwnode_get_next_child_node() comments Johan Hovold
2026-11-13 17:49 ` Rafael J. Wysocki (Intel)
2026-11-16 14:54 ` Johan Hovold [this message]
2026-11-16 15:22 ` Rafael J. Wysocki (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avsZN96lgaW5IHdh@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®