mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Jason Perlow <jperlow@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Darshit Shah <darnshah@amazon.de>,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/portdrv: Do not advertise DPC on ports without an AER capability
Date: Mon, 16 Nov 2026 23:05:09 +0100	[thread overview]
Message-ID: <avt-FbT69lemI4b0@wunner.de> (raw)
In-Reply-To: <9ed2d8fb-fad5-44b3-82a2-0021edb405f4@gmail.com>

On Mon, Nov 16, 2026 at 04:39:23PM -0500, Jason Perlow wrote:
> Commit 97ca178c899d ("PCI/DPC: Allow DPC on all Downstream Ports when OS
> controls AER") makes get_port_device_capability() advertise the DPC
> service on any port with a DPC capability when the host bridge owns AER.
> It dropped the earlier per-port test for an AER capability.
> 
> dpc_probe() still returns -ENOTSUPP unless pcie_aer_is_native() is true
> or pcie_ports=dpc-native is set, and pcie_aer_is_native() is never true
> for a port without an AER capability.  Such ports now get a DPC service
> device that can never bind, and every boot logs an error for each of
> them.  For example, on a MacBookPro16,1 the Cannon Lake PCH root ports
> have DPC but no AER capability:
> 
>   dpc 0000:00:1b.0:pcie008: probe with driver dpc failed with error -524
>   dpc 0000:00:1c.0:pcie008: probe with driver dpc failed with error -524

DPC does not mandate AER support, so the condition in
get_port_device_capability (which you're changing) is correct whereas
the condition in dpc_probe() is wrong.  There's a patch pending which
removes it:

https://lore.kernel.org/r/2ce502e5caa57db01e0a7bbc781210b66b73bec8.1790531238.git.lukas@wunner.de/

I'll respin the patch shortly.  The patch is tagged for stable.
If you can't live with the error message until the patch gets
picked up by the kernel version you're using, replace the
-ENOTSUPP with -ENODEV to silence the error.

Thanks,

Lukas

  reply	other threads:[~2026-11-16 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 21:39 Jason Perlow
2026-11-16 22:05 ` Lukas Wunner [this message]
2026-11-16 22:08   ` Perlow, Jason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avt-FbT69lemI4b0@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=darnshah@amazon.de \
    --cc=jperlow@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®