From: Jarkko Sakkinen <jarkko@kernel.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: David Howells <dhowells@redhat.com>,
bpf@vger.kernel.org, dm-devel@lists.linux.dev,
fsverity@lists.linux.dev, keyrings@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
linux-security-module@vger.kernel.org,
Alasdair Kergon <agk@redhat.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>, Alex Shi <alexs@kernel.org>,
Anastasia Eskova <anastasia.eskova@ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrii Nakryiko <andrii@kernel.org>,
Benjamin Marzinski <bmarzins@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Dongliang Mu <dzm91@hust.edu.cn>,
Eduard Zingerman <eddyz87@gmail.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
Eric Biggers <ebiggers@kernel.org>,
Ignat Korchagin <ignat@linux.win>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
James Morris <jmorris@namei.org>, Jiri Olsa <jolsa@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Randy Dunlap <rdunlap@infradead.org>,
Roberto Sassu <roberto.sassu@huawei.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Song Liu <song@kernel.org>, Sven Schnelle <svens@linux.ibm.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Vasily Gorbik <gor@linux.ibm.com>,
Yanteng Si <si.yanteng@linux.dev>,
Yonghong Song <yonghong.song@linux.dev>
Subject: Re: [PATCH v13 0/7] KEYS: Replace assoc_array with rhashtable
Date: Mon, 16 Nov 2026 21:37:25 +0200 [thread overview]
Message-ID: <avtbdRYtBl3fsXBF@kernel.org> (raw)
In-Reply-To: <20261116120722.99807Ac6-hca@linux.ibm.com>
On Mon, Nov 16, 2026 at 01:07:22PM +0100, Heiko Carstens wrote:
> Hi Jarkko,
>
> On Sat, Nov 14, 2026 at 09:36:24PM +0200, Jarkko Sakkinen wrote:
> > The keyrings subsystem is the sole user of assoc_array. It has over 1700
> > lines of code, no test suite, and a long history of bugs, with LLMs now
> > finding more.
> >
> > This unfortunate outcome has evolved over time by large from the shortage
> > of in-kernel callers, time bandwidth and 3rd party contributors. What the
> > keyrings subsystem needs is just a generic key-value store, which performs
> > well with sparse key sets. Replace assoc_array with an rhashtable-backed
> > keyring index and remove assoc_array from the kernel.
>
> ...
>
> > v13:
> > - s390/cert_store: Hold key reference across key_unlink(), and ignore -ENOENT.
> > - s390/cert_store: Add "s390/cert_store: Read-lock keyring semaphore in
> > invalidate_keyring_keys()".
>
> Actually I had / have a patch series of 15 small patches ready to address
> various bugs in certstore, including yours. I'll send them later - a few
> (or many) collide with your patches. Not sure how we coordinate this.
That is perfect. I don't honestly care about patch authorship in this case
too much. Do whatever you want :-) I'm just happy to get them out of the
way.
Br, Jarkko
prev parent reply other threads:[~2026-11-16 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 19:36 Jarkko Sakkinen
2026-11-14 19:36 ` [PATCH v13 1/7] s390/cert_store: Pin the user session keyring Jarkko Sakkinen
2026-11-14 19:36 ` [PATCH v13 2/7] s390/cert_store: Return an owned reference from find_cs_keyring() Jarkko Sakkinen
2026-11-14 19:36 ` [PATCH v13 3/7] s390/cert_store: Skip keys that disappeared during invalidation Jarkko Sakkinen
2026-11-14 19:36 ` [PATCH v13 4/7] s390/cert_store: Read-lock keyring semaphore in invalidate_keyring_keys() Jarkko Sakkinen
2026-11-14 19:36 ` [PATCH v13 5/7] KEYS: Introduce keyring_is_empty() Jarkko Sakkinen
2026-11-14 19:36 ` [PATCH v13 6/7] KEYS: Replace assoc_array with rhashtable Jarkko Sakkinen
2026-11-14 20:24 ` bot+bpf-ci
2026-11-14 20:38 ` Jarkko Sakkinen
2026-11-14 19:36 ` [PATCH v13 7/7] lib: Remove assoc_array Jarkko Sakkinen
2026-11-16 12:07 ` [PATCH v13 0/7] KEYS: Replace assoc_array with rhashtable Heiko Carstens
2026-11-16 19:37 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avtbdRYtBl3fsXBF@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agk@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=anastasia.eskova@ibm.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bmarzins@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dhowells@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=dzm91@hust.edu.cn \
--cc=ebiggers@kernel.org \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=fsverity@lists.linux.dev \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=ignat@linux.win \
--cc=ihor.solodrai@linux.dev \
--cc=jmorris@namei.org \
--cc=jolsa@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mpatocka@redhat.com \
--cc=oberpar@linux.ibm.com \
--cc=paul@paul-moore.com \
--cc=rdunlap@infradead.org \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=si.yanteng@linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=svens@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=yonghong.song@linux.dev \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®