mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Naveen N Rao <naveen@kernel.org>,
	Alexandru Elisei <alexandru.elisei@arm.com>
Subject: Re: [PATCH v3] KVM: Skip gfn-based MMU notifier invalidations for guest_memfd-only memslots
Date: Mon, 16 Nov 2026 15:56:06 -0800	[thread overview]
Message-ID: <avuYFqt_DAnCiM9U@seanjc-mac.roam.internal> (raw)
In-Reply-To: <aviC2OUjvNz_ubZr@google.com>

On Sat, Nov 14, 2026, Sean Christopherson wrote:
> On Fri, Nov 13, 2026, Lorenzo Stoakes (ARM) wrote:
> > On Fri, Nov 13, 2026 at 08:40:00AM -0800, Sean Christopherson wrote:
> > And a VMM that's doing something broken (i.e. trying to take advantage of this
> > as a vulnerability), could then intentionally set up a gmem-only slot to point
> > at ordinary anon memory, munmap(), and have a UAF on the underlying folio due to
> > no MMU notifier invalidation.
> 
> Ya, Sashiko flagged this as well.  I was initially planning on adding the check
> in kvm_mmu_prefetch_sptes(), but adding the check in kvm_prefetch_pages() is
> better since the work-in-progress prefetching for x86's TDP MMU will share some
> of the prefetching checks, but will go through the normal fault-in path instead
> of using kvm_prefetch_pages().  The return should be -EINVAL or so though.
> 
> I'll send a patch on Monday. 

Slight addendum: I'm going to a v4 of this "series".  I original thought the bug
was already reachable, but I was conflating this issue with something else.

      reply	other threads:[~2026-11-16 23:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 16:40 Sean Christopherson
2026-11-13 17:25 ` Lorenzo Stoakes (ARM)
2026-11-14 15:48   ` Sean Christopherson
2026-11-16 23:56     ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avuYFqt_DAnCiM9U@seanjc-mac.roam.internal \
    --to=seanjc@google.com \
    --cc=alexandru.elisei@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=naveen@kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®