From: "Xu Xin (vivo)" <xu.xin@linux.dev>
To: Nico Pache <nico.pache@linux.dev>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <liam@infradead.org>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
Kiryl Shutsemau <kas@kernel.org>, Yu Zhao <yuzhao@google.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Matthew Brost <matthew.brost@intel.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Byungchul Park <byungchul@sk.com>,
Gregory Price <gourry@gourry.net>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
Usama Arif <usamaarif642@gmail.com>,
aarcange@redhat.com
Subject: Re: [PATCH v2 2/2] mm/ksm: prevent zero-page remapping during ksmd-triggered THP splits
Date: Tue, 17 Nov 2026 09:02:07 +0800 [thread overview]
Message-ID: <avunj4dVyiLovWL0@dgvxl46587.localhost.localdomain> (raw)
In-Reply-To: <8375728d-c1e7-4033-8096-5d98d1bc36e9@linux.dev>
On Mon, Nov 16, 2026 at 04:58:55PM -0700, Nico Pache wrote:
>
>
> On 11/16/26 3:21 PM, David Hildenbrand (Arm) wrote:
> > On 10/25/26 18:39, Nico Pache (Red Hat) wrote:
> > > Since commit b1f202060afe ("mm: remap unused subpages to shared zeropage
> > > when splitting isolated thp"), splitting an anonymous THP remaps all
> > > zero-filled subpages to the shared zeropage via TTU_USE_SHARED_ZEROPAGE.
> > > This flag is set unconditionally for every anonymous folio split,
> > > including splits triggered by KSM.
> > >
> > > When KSM is enabled with THP=always, this causes two regressions:
> > >
> > > 1. use_zero_pages=1: KSM calls try_to_merge_one_page() which triggers
> > > split_huge_page(). The split remaps all 512 zero-filled subpages to
> > > the shared zeropage at once, freeing the entire 2MB THP when KSM only
> > > intended to process a single 4KB page. This bypasses KSM's
> > > pages_to_scan rate limiting, causing ~1GB to be freed almost
> > > instantly.
> > >
> > > 2. use_zero_pages=0: The same split side-effect occurs through the
> > > stable/unstable tree merge paths. Each pages_to_scan iteration
> > > triggers an expensive split_huge_page() that silently frees 2MB,
> > > while the scanner wastes cycles on tree searches for zero-filled
> > > pages that were already freed as a side-effect.
> > >
> > > Introduce current_is_ksmd(), which uses kthread_func() to check whether
> > > the current task is the KSM scanning thread, and use it in
> > > try_to_map_unused_to_zeropage() to skip zero-page remapping when the
> > > split is triggered by ksmd.
> > >
> > > Fixes: b1f202060afe ("mm: remap unused subpages to shared zeropage when splitting isolated thp")
> > > Signed-off-by: Nico Pache (Red Hat) <nico.pache@linux.dev>
> > > ---
> >
> > [...]
> >
> > > static bool __ksm_should_add_vma(const struct file *file, vma_flags_t vma_flags)
> > > {
> > > if (vma_flags_test(&vma_flags, VMA_MERGEABLE_BIT))
> > > diff --git a/mm/migrate.c b/mm/migrate.c
> > > index 7bdcdb57652f..c33ae3fa1043 100644
> > > --- a/mm/migrate.c
> > > +++ b/mm/migrate.c
> > > @@ -305,6 +305,9 @@ static bool try_to_map_unused_to_zeropage(struct page_vma_mapped_walk *pvmw,
> > > if (PageCompound(page) || PageHWPoison(page))
> > > return false;
> >
> > This really needs a comment like:
> >
> > /*
> > * When the split is triggered by KSM, let it take care of scanning-for and
> > * de-duplicating the shared zeropage.
> > */
>
> Ack! ill wait a day or two before sending a fixup in case others review.
> >
> > > + if (current_is_ksmd())
> > > + return false;
> > > +
> > > VM_BUG_ON_PAGE(!PageAnon(page), page);
> > > VM_BUG_ON_PAGE(!PageLocked(page), page);
> > > VM_BUG_ON_PAGE(pte_present(old_pte), page);
> > >
> >
> > I'm still a bit unclear of what happens when the split is triggered by something
> > else in the system just before we walk into this THP.
> >
> > Like, imagine the deferred shrinker scans for 0-filled pages and splits under
> > memory pressure. Then KSM scans and essentially skips the (now-split) THP?
>
> IIUC, we dont skip the (now-split) THP (ksm works by page, not folio), we
> would only skip over the parts that were remapped to the zeropage. and
> because the shrinker already split the folio, it wont end up even needing to
> split it.
Yes, that's right, KSM would skip zero page during scan_get_next_rmap_item, but still
scan non-zero parts.
>
> Inversely, if ksm does run into a large folio, it splits it, but doesnt do
> the remapping. Which KSM will either eventually deduplicate itself (and in
> the case of use_zero_page=1, it will also do the zeropage remapping).
>
> I asked our robot overlords if im missing anything and it did find this
> potential issue:
>
> KSM could trigger alloc/reclaim that would then prevent the zero-page
> remapping for any reclaim done under the daemon.
>
> It did suggest this fix `current_is_ksmd() && !current->reclaim_state`
> basically check if we are in reclaim and ksm. This would close the gap.
>
Yeah, `current_is_ksmd() && !current->reclaim_state` would be more precise.
Generally, LGTM if you fix that.
> Or we could go back to adding a flag to split function (but i believe this
> is still somewhat cleaner and doesnt complicate the already messy split
> code).
>
> Cheers,
> -- Nico
>
>
>
>
>
> >
>
prev parent reply other threads:[~2026-11-17 1:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 17:39 [PATCH v2 0/2] MM: Tighten control over zero-page remapping Nico Pache (Red Hat)
2026-10-25 17:39 ` [PATCH v2 1/2] mm/huge_memory.c: skip zero-page remapping when underused THP shrinker is disabled Nico Pache (Red Hat)
2026-10-25 20:28 ` Barry Song
2026-10-25 21:48 ` Nico Pache
2026-10-26 4:52 ` Barry Song
2026-10-26 20:02 ` Nico Pache
2026-10-26 20:58 ` Barry Song
2026-10-26 21:33 ` Nico Pache
2026-11-16 22:30 ` David Hildenbrand (Arm)
2026-11-16 23:08 ` Nico Pache
2026-10-25 17:39 ` [PATCH v2 2/2] mm/ksm: prevent zero-page remapping during ksmd-triggered THP splits Nico Pache (Red Hat)
2026-11-16 22:21 ` David Hildenbrand (Arm)
2026-11-16 23:58 ` Nico Pache
2026-11-17 1:02 ` Xu Xin (vivo) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avunj4dVyiLovWL0@dgvxl46587.localhost.localdomain \
--to=xu.xin@linux.dev \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=byungchul@sk.com \
--cc=chengming.zhou@linux.dev \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=kas@kernel.org \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=nico.pache@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=usama.arif@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=ying.huang@linux.alibaba.com \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®