mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Martin Tuma" <martin.tuma@digiteqautomotive.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	linux-media@vger.kernel.org,
	"Gustavo Silva" <gustavograzs@gmail.com>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Ramona Alexandra Nechita" <ramona.nechita@analog.com>,
	"Tomislav Denis" <tomislav.denis@avl.com>,
	"Jorge Marques" <jorge.marques@analog.com>,
	"Petre Rodan" <petre.rodan@subdimension.ro>,
	"Dan Robertson" <dan@dlrobertson.com>,
	"Jianping Shen" <Jianping.Shen@de.bosch.com>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Maxwell Doose" <maxwell@maxwelld.cc>,
	"Tomasz Duszynski" <tduszyns@gmail.com>,
	"Esben Haabendal" <esben@geanix.com>,
	"Narcisa Ana Maria Vasile" <narcisaanamaria12@gmail.com>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Vasileios Amoiridis" <vassilisamir@gmail.com>,
	"Abhash Jha" <abhashkumarjha123@gmail.com>,
	"Puranjay Mohan" <puranjay@kernel.org>,
	"Nishant Malpani" <nish.malpani25@gmail.com>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Linus Walleij" <linusw@kernel.org>,
	"Jonathan Cameron" <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [PATCH 00/35] iio: closing default trigger handling leaks
Date: Tue, 17 Nov 2026 09:20:42 +0200	[thread overview]
Message-ID: <avwASv6SGjvLG0jr@ashevche-desk.local> (raw)
In-Reply-To: <20261116014823.3132576-1-jic23@kernel.org>

On Mon, Nov 16, 2026 at 01:47:48AM +0000, Jonathan Cameron wrote:
> 
> Note this is compile tested only!  I definitely want a few people
> to test that I didn't break everything.
> 
> This is the first part of what I think is a long term solution to the
> currently really fragile ordering constraints around setting default
> triggers. Today these are set by iio_dev->trig = iio_trigger_get(trig).
> The reference is only released on the iio_dev.release callback and
> only if we have set the mode to include one that means there might be
> a trigger set. That mode set only occurs when a buffer is registered.
> Thus trigger release only works if we have already registered a buffer.
> 
> One solution would be to reorder so that the default trigger is always
> set after the buffer registration (we have had various recent proposed
> patches to do that for individual drivers) but that is non obvious and
> fragile.
> 
> The solution here is easier to reason about. Decouple the setting
> of the default trigger from the acquisition of a reference. Thus
> we can acquire the reference in iio_device_register() when we know
> all the conditions for it's release have been achieved.
> So that's all we do in this part 1 series.
> 
> Part 2 will address immutable triggers and those that are effectively
> immutable but predate that logic. That is those that set a one to one
> relationship between device and trigger.  That change is rather less
> mechanical than this one and 35 patches is really a bit big anyway
> even if most of them are small!
> 
> Part 3 and beyond will move to a situation where the iio_dev->trig
> will become opaque. That should stop anyone manipulating that directly.
> I have a few related cunning plans to test out before we get to that,
> not because the particular challenge is hard, but because they will
> trample on the same code.

> Jonathan Cameron (35):
>   iio: core: add default_trigger and take reference in
>     iio_device_register()

I have reviewed the first patch and briefly looked at the rest which seems
like a semi-automatic translation in most cases.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

>   media: pci: mgb4: use IIO default_trigger
>   iio: chemical: ens160: use default_trigger
>   iio: adc: ad4130: use default_trigger
>   iio: adc: ad4170-4: use default_trigger
>   iio: adc: ad7768-1: use default_trigger
>   iio: adc: ad7779: use default_trigger
>   iio: adc: ti-ads131e08: use default_trigger
>   iio: addac: ad74115: use default_trigger
>   iio: addac: ad74413r: use default_trigger
>   iio: temperature: tmp006: use default_trigger
>   iio: adc: ad4062: use default_trigger
>   iio: accel: bma220: use default_trigger
>   iio: accel: bma400: use default_trigger
>   iio: imu: smi330: use default_trigger
>   iio: light: acpi-als: use default_trigger
>   iio: chemical: scd30: use default_trigger
>   iio: accel: bma180: use default_trigger
>   iio: accel: kxcjk-1013: use default_trigger
>   iio: accel: mma8452: use default_trigger
>   iio: chemical: ccs811: use default_trigger
>   iio: pressure: mpl3115: use default_trigger
>   iio: common: st_sensors: use default_trigger
>   iio: common: hid-sensors: use default_trigger
>   iio: pressure: bmp280: use default_trigger
>   iio: light: vl6180: use default_trigger
>   iio: gyro: itg3200: use default_trigger
>   iio: imu: bmi160: use default_trigger
>   iio: accel: adxl355: use default_trigger
>   iio: gyro: adxrs290: use default_trigger
>   iio: accel: adxl372: use default_trigger
>   iio: light: si1145: use default_trigger
>   iio: adc: ti-tsc2046: use default_trigger
>   iio: accel: mxc4005: use default_trigger
>   iio: gyro: mpu3050: use default_trigger

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2026-11-17  7:20 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  1:47 Jonathan Cameron
2026-11-16  1:47 ` [PATCH 01/35] iio: core: add default_trigger and take reference in iio_device_register() Jonathan Cameron
2026-11-16 10:14   ` Linus Walleij
2026-11-16  1:47 ` [PATCH 02/35] media: pci: mgb4: use IIO default_trigger Jonathan Cameron
2026-11-16  1:47 ` [PATCH 03/35] iio: chemical: ens160: use default_trigger Jonathan Cameron
2026-11-16  1:47 ` [PATCH 04/35] iio: adc: ad4130: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 05/35] iio: adc: ad4170-4: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 06/35] iio: adc: ad7768-1: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 07/35] iio: adc: ad7779: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 08/35] iio: adc: ti-ads131e08: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 09/35] iio: addac: ad74115: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 10/35] iio: addac: ad74413r: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 11/35] iio: temperature: tmp006: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 12/35] iio: adc: ad4062: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 13/35] iio: accel: bma220: " Jonathan Cameron
2026-11-16 10:13   ` Linus Walleij
2026-11-16 17:27   ` Petre Rodan
2026-11-16  1:48 ` [PATCH 14/35] iio: accel: bma400: " Jonathan Cameron
2026-11-16 10:13   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 15/35] iio: imu: smi330: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 16/35] iio: light: acpi-als: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 17/35] iio: chemical: scd30: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 18/35] iio: accel: bma180: " Jonathan Cameron
2026-11-16 10:12   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 19/35] iio: accel: kxcjk-1013: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 20/35] iio: accel: mma8452: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 21/35] iio: chemical: ccs811: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 22/35] iio: pressure: mpl3115: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 23/35] iio: common: st_sensors: " Jonathan Cameron
2026-11-16 10:12   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 24/35] iio: common: hid-sensors: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 25/35] iio: pressure: bmp280: " Jonathan Cameron
2026-11-16 10:11   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 26/35] iio: light: vl6180: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 27/35] iio: gyro: itg3200: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 28/35] iio: imu: bmi160: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 29/35] iio: accel: adxl355: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 30/35] iio: gyro: adxrs290: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 31/35] iio: accel: adxl372: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 32/35] iio: light: si1145: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 33/35] iio: adc: ti-tsc2046: " Jonathan Cameron
2026-11-16 14:19   ` Oleksij Rempel
2026-11-16  1:48 ` [PATCH 34/35] iio: accel: mxc4005: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 35/35] iio: gyro: mpu3050: " Jonathan Cameron
2026-11-16 10:11   ` Linus Walleij
2026-11-17  7:20 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avwASv6SGjvLG0jr@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=Jianping.Shen@de.bosch.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=abhashkumarjha123@gmail.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=dan@dlrobertson.com \
    --cc=dlechner@baylibre.com \
    --cc=esben@geanix.com \
    --cc=gustavograzs@gmail.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=jorge.marques@analog.com \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=martin.tuma@digiteqautomotive.com \
    --cc=maxwell@maxwelld.cc \
    --cc=mchehab@kernel.org \
    --cc=narcisaanamaria12@gmail.com \
    --cc=nish.malpani25@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=o.rempel@pengutronix.de \
    --cc=petre.rodan@subdimension.ro \
    --cc=puranjay@kernel.org \
    --cc=ramona.nechita@analog.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tduszyns@gmail.com \
    --cc=tomislav.denis@avl.com \
    --cc=vassilisamir@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®