From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: "Stuart Hayes" <stuart.w.hayes@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andrew Morton" <akpm@osdl.org>,
"Doug Warzecha" <Douglas_Warzecha@dell.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] platform/x86: dell: dcdbas: Actually wait for the host control SMI
Date: Tue, 17 Nov 2026 09:54:28 +0200 [thread overview]
Message-ID: <avwINFo8rNjSDN3A@ashevche-desk.local> (raw)
In-Reply-To: <62690b76d5cb95113b01092c8e3944fbb21a0922.1794861287.git.rosenp@gmail.com>
On Mon, Nov 16, 2026 at 12:40:49PM -0800, Rosen Penev wrote:
> For SMI types 2 and 3, host_control_smi() writes the command status as
> -1, raises the SMI and then waits for the BIOS to change the status:
>
> while (apm_cmd->status == ESM_STATUS_CMD_UNSUCCESSFUL) {
>
> apm_cmd->status is a plain memory read, and neither outb() nor inb()
> tells the compiler that memory may have changed, so the compiler
> assumes status is still -1. The loop then has no side effects and its
> return value is not used, so it is removed entirely: in the generated
> code, the read of the control port is followed directly by the return.
> The kernel goes on to power off right after raising the host control
> SMI, without waiting for the BIOS to accept it.
>
> The type 1 wait polls the APM status port instead, in a loop that
> counts down TIMEOUT_USEC_SHORT_SEMA_BLOCKING iterations and relies on
> each inb() taking about a microsecond.
>
> Convert both waits to read_poll_timeout_atomic(), using READ_ONCE() for
> the status in memory and inb() for the status port, 1us apart for up to
> TIMEOUT_USEC_SHORT_SEMA_BLOCKING microseconds as the name suggests, and
> return its error. That is -ETIMEDOUT rather than -ETIME, but both
> callers ignore the return value. With the delay plus the port read, the
> type 1 worst-case wait grows from about 10ms to about 20ms, which only
> matters when the BIOS never answers.
>
> This removes the last users of num_ticks and EXPIRED_TIMER.
...
> + ret = read_poll_timeout_atomic(inb, cmd_status,
> + cmd_status != ESM_STATUS_CMD_UNSUCCESSFUL,
> + 1, TIMEOUT_USEC_SHORT_SEMA_BLOCKING,
> + false, PCAT_APM_STATUS_PORT);
readx_poll_timeout_atomic() is your friend.
...
> + ret = read_poll_timeout_atomic(READ_ONCE, cmd_status,
> + cmd_status != ESM_STATUS_CMD_UNSUCCESSFUL,
> + 1, TIMEOUT_USEC_SHORT_SEMA_BLOCKING,
> + false, apm_cmd->status);
In the similar way.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-17 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 20:40 [PATCH v2 0/4] platform/x86: dell: dcdbas: Fix SMI completion wait and buffer handling Rosen Penev
2026-11-16 20:40 ` [PATCH v2 1/4] platform/x86: dell: dcdbas: Actually wait for the host control SMI Rosen Penev
2026-11-17 7:54 ` Andy Shevchenko [this message]
2026-11-16 20:40 ` [PATCH v2 2/4] platform/x86: dell: dcdbas: Suppress bind attributes of the platform driver Rosen Penev
2026-11-16 20:40 ` [PATCH v2 3/4] platform/x86: dell: dcdbas: Release the SMI buffer in remove Rosen Penev
2026-11-16 20:40 ` [PATCH v2 4/4] platform/x86: dell: dcdbas: Validate the WSMT buffer description Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwINFo8rNjSDN3A@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Douglas_Warzecha@dell.com \
--cc=akpm@osdl.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®