From: Alain Volmat <alain.volmat@foss.st.com>
To: Joshua Crofts <crofts@kernel.org>
Cc: Vladimir Moravcevic <vmoravcevic@axiado.com>,
Tzu-Hao Wei <twei@axiado.com>, Swark Yang <syang@axiado.com>,
Prasad Bolisetty <pbolisetty@axiado.com>,
Mark Brown <broonie@kernel.org>,
Karthikeyan Mitran <kmitran@axiado.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
Michal Simek <michal.simek@amd.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Jyan Chou <jyanchou@realtek.com>,
Yu-Chun Lin <eleanor.lin@realtek.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
"Sowjanya Komatineni" <skomatineni@nvidia.com>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-mediatek@lists.infradead.org>,
<linux-rockchip@lists.infradead.org>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 04/11] spi: stm32: remove redundant pm_runtime_dont_use_autosuspend() calls
Date: Tue, 17 Nov 2026 10:04:40 +0100 [thread overview]
Message-ID: <avwYqLu0nEGsfAv6@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <20261108-spi-dont-use-autosuspend-v1-4-3587b0183cbe@kernel.org>
Hi,
On Sun, Nov 08, 2026 at 01:16:51PM +0100, Joshua Crofts wrote:
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---
> drivers/spi/spi-stm32.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index 4c3ae546afc0..95994278cdaa 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -2544,7 +2544,6 @@ static int stm32_spi_probe(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> - pm_runtime_dont_use_autosuspend(&pdev->dev);
>
> if (spi->mdma_rx)
> dma_release_channel(spi->mdma_rx);
> @@ -2574,7 +2573,6 @@ static void stm32_spi_remove(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> - pm_runtime_dont_use_autosuspend(&pdev->dev);
>
> if (ctrl->dma_tx)
> dma_release_channel(ctrl->dma_tx);
>
Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>
Regards,
Alain
> --
> 2.56.0
>
next prev parent reply other threads:[~2026-11-17 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 12:16 [PATCH 00/11] spi: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 01/11] spi: axiado: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 02/11] spi: cadence-quadspi: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 03/11] spi: cadence: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 04/11] spi: stm32: " Joshua Crofts
2026-11-17 9:04 ` Alain Volmat [this message]
2026-11-08 12:16 ` [PATCH 05/11] spi: stm32-qspi: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 06/11] spi: zynqmp-gqspi: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 07/11] spi: mtk-nor: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 08/11] spi: orion: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 09/11] spi: rockchip-sfc: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 10/11] spi: rtk-nor: " Joshua Crofts
2026-11-08 12:16 ` [PATCH 11/11] spi: tegra210-quad: " Joshua Crofts
2026-11-09 20:12 ` [PATCH 00/11] spi: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwYqLu0nEGsfAv6@gnbcxd0016.gnb.st.com \
--to=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=crofts@kernel.org \
--cc=eleanor.lin@realtek.com \
--cc=heiko@sntech.de \
--cc=jonathanh@nvidia.com \
--cc=jyanchou@realtek.com \
--cc=kmitran@axiado.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=pbolisetty@axiado.com \
--cc=skomatineni@nvidia.com \
--cc=syang@axiado.com \
--cc=thierry.reding@kernel.org \
--cc=twei@axiado.com \
--cc=vmoravcevic@axiado.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®