From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
To: SJ Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
David Hildenbrand <david@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <brendan.jackman@linux.dev>,
Zi Yan <ziy@nvidia.com>, Dev Jain <dev.jain@arm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH] mm/compaction: do not skip the free scanner's periodic lock drop
Date: Tue, 17 Nov 2026 10:29:42 +0000 [thread overview]
Message-ID: <avwsUxvOymaJqcXX@shutemov.name> (raw)
In-Reply-To: <20261117013702.109081-1-sj@kernel.org>
On Mon, Nov 16, 2026 at 05:37:02PM -0800, SJ Park wrote:
> On Mon, 16 Nov 2026 12:57:45 +0000 "Kiryl Shutsemau (Meta)" <kas@kernel.org> wrote:
>
> > isolate_freepages_block() drops zone->lock, checks for a fatal signal
> > and calls cond_resched() at every pfn that is a multiple of
> > COMPACT_CLUSTER_MAX.
> >
> > With a stride above one, the scan steps over a compound page, or over a
> > high-order free page it has just isolated, to a pfn that is not a
> > multiple of the stride. From there it never reaches a multiple of
> > COMPACT_CLUSTER_MAX, so the rest of the pageblock is scanned without the
> > check, possibly with zone->lock held and interrupts off.
> >
> > Count probes instead, and check every COMPACT_CLUSTER_MAX of them.
>
> Makes sense to me.
>
> >
> > Fixes: 4fca9730c51d ("mm, compaction: sample pageblocks for free pages")
>
> I understand you intentionally not Cc-ing stable@, buecase the user impact is
> not that bad. I think that makes sense. I just wanted to call out this for a
> case that it was not intentional.
Right, I have not see the actual user effect of the bug.
> > Signed-off-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> > ---
> > mm/compaction.c | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/mm/compaction.c b/mm/compaction.c
> > index f1b2060eb201..4465c1551406 100644
> > --- a/mm/compaction.c
> > +++ b/mm/compaction.c
> > @@ -579,7 +579,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
> > unsigned int stride,
> > bool strict)
> > {
> > - int nr_scanned = 0, total_isolated = 0;
> > + int nr_scanned = 0, nr_probes = 0, total_isolated = 0;
> > struct page *page;
> > unsigned long flags = 0;
> > bool locked = false;
> > @@ -599,13 +599,15 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
> > /*
> > * Periodically drop the lock (if held) regardless of its
> > * contention, to give chance to IRQs. Abort if fatal signal
> > - * pending.
> > + * pending. Count probes rather than pfns, as the scan does not
> > + * always land on a multiple of COMPACT_CLUSTER_MAX.
> > */
> > - if (!(blockpfn % COMPACT_CLUSTER_MAX)
> > - && compact_unlock_should_abort(&cc->zone->lock, flags,
> > - &locked, cc))
> > + if (!(nr_probes % COMPACT_CLUSTER_MAX) &&
> > + compact_unlock_should_abort(&cc->zone->lock, flags,
> > + &locked, cc))
>
> Why don't you let the later two lines unchanged? No strong opinion, no
> blocker.
&& on the new line is odd to me.
> Reviewed-by: SJ Park <sj@kernel.org>
Thanks!
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-11-17 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:57 Kiryl Shutsemau (Meta)
2026-11-17 1:37 ` SJ Park
2026-11-17 10:29 ` Kiryl Shutsemau (Meta) [this message]
2026-11-17 5:34 ` Dev Jain
2026-11-17 10:28 ` Kiryl Shutsemau (Meta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwsUxvOymaJqcXX@shutemov.name \
--to=kas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®