mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kayra Cizmeci <kayracizmeci@gmail.com>
To: peterz@infradead.org, vincent.guittot@linaro.org,
	 Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	 Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	 Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	 Valentin Schneider <vschneid@redhat.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Cc: christian.loehle@arm.com, elif.topuz@arm.com,
	 linux-kernel@vger.kernel.org, mingo@kernel.org, sh@gentwo.org
Subject: Re: [PATCH v5] sched/eevdf: Fix vprot across reweighting
Date: Tue, 17 Nov 2026 19:15:12 +0300	[thread overview]
Message-ID: <avx3Q0WvV5lgAhWA@scheduler.schedules> (raw)
In-Reply-To: <20261016153721.7843-1-kayracizmeci@gmail.com>

On Fri, Oct 16, 2026 at 06:37:20PM +0300, Kayra Cizmeci wrote:
> Currently in reweighting, while a tasks vruntime changes dead protection
> could go alive, or alive protection could decrease, increase and go dead.
> Fix it in reweight_eevdf(), and just cancel it in the sched_change_end()
> path.
> 
> Fixes: 80390ead2080 ("sched/fair: Separate se->vlag from se->vprot")
> Fixes: bcd74b2ffdd0 ("sched/fair: Only set slice protection at pick time")
> Suggested-by: Vincent Guittot <vincent.guittot@linaro.org>
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> Signed-off-by: Kayra Cizmeci <kayracizmeci@gmail.com>
> ---
> Changes v4->v5:
> * Use Vincent's comment
> * Grab Tags
> 
> v4: https://lore.kernel.org/lkml/20261016150402.6952-1-kayracizmeci@gmail.com/
> 
> Not tested.

Well I got bored, so I tested this. I don't know what more to do on this
patch. I already pinged. So the only thing left was testing, I guess.

The results were good. I tried to verify 2 things:

* Only sched change thingies enter the newly added path in enqueue_task_fair()

* All tasks protection gets handled correctly

There were ~318000 reweights of curr, ~48000 of them were alive.
No exceptions :-). Or :-( since if there was an exception atleast it
would be fun to check it out.


Cheers,

Kayra

      parent reply	other threads:[~2026-11-17 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 15:37 Kayra Cizmeci
2026-11-02 13:31 ` Kayra Cizmeci
2026-11-17 16:15 ` Kayra Cizmeci [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avx3Q0WvV5lgAhWA@scheduler.schedules \
    --to=kayracizmeci@gmail.com \
    --cc=bsegall@google.com \
    --cc=christian.loehle@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=elif.topuz@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sh@gentwo.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®