From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Orgad Shaneh <orgads@gmail.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
ardb@kernel.org
Subject: Re: [PATCH] MIPS: OCTEON: compute the FDT CRC in device_tree_init()
Date: Tue, 17 Nov 2026 17:12:47 +0100 [thread overview]
Message-ID: <avx8_1ffn4OlS4YD@alpha.franken.de> (raw)
In-Reply-To: <20261027060214.2687878-1-orgads@gmail.com>
On Tue, Oct 27, 2026 at 06:02:14AM +0000, Orgad Shaneh wrote:
> device_tree_init() assigns initial_boot_params directly and never calls
> early_init_dt_verify(), so of_fdt_crc32 stays 0 and every boot logs
>
> OF: fdt: not creating '/sys/firmware/fdt': CRC check failed
>
> whether the blob was passed by the bootloader, appended or built in.
> Call early_init_dt_verify() once the prune and the MAC address fill-in
> are done with the blob, so the CRC matches what of_fdt_raw_init() reads
> back. x86 had the same omission, fixed by commit 628df9dc5ad8
> ("x86/devicetree: Initialize device tree before using it").
>
> Fixes: 08d53aa58cb1 ("of/fdt: export fdt blob as /sys/firmware/fdt")
> Assisted-by: LLM
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
> Tested on a CN6335 board (internal device tree, Cavium U-Boot 1.1.1),
> in a 7.3-based tree: the warning is gone and /sys/firmware/fdt holds the
> 11551-byte blob. mips-next with cavium_octeon_defconfig prints the
> warning on the same board without this patch.
>
> arch/mips/cavium-octeon/setup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
> index 7497be7b9431..fa8273799b94 100644
> --- a/arch/mips/cavium-octeon/setup.c
> +++ b/arch/mips/cavium-octeon/setup.c
> @@ -1213,6 +1213,8 @@ void __init device_tree_init(void)
> }
> if (fill_mac)
> octeon_fill_mac_addresses();
> + /* After the edits above, so the CRC covers the final blob */
> + early_init_dt_verify(initial_boot_params, __pa(initial_boot_params));
> unflatten_and_copy_device_tree();
> init_octeon_system_type();
> }
I've applied https://lore.kernel.org/all/20261025192918.586220-1-carl.smith@alliedtelesis.co.nz/ to mips-next, which is doing the same.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2026-11-17 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 6:02 Orgad Shaneh
2026-11-17 16:12 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avx8_1ffn4OlS4YD@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=ardb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®